Disallow phantom type parameter/member in classes #2442
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasstucki
requested review from
odersky
and removed request for
OlivierBlanvillain
liufengyun
reviewed
May 18, 2017
| else if (!isParam && isPhantom && !tdef.symbol.owner.isStaticOwner) | ||
| ctx.error("Non static classes cannot have phantom type members", tdef.pos) | ||
| tdef | ||
| } |
There was a problem hiding this comment.
A small comment: may this be done in RefChecks where a lot of checking happens?
There was a problem hiding this comment.
I will try. I also felt uneasy adding all those checks in there.
There was a problem hiding this comment.
Moved it to Checking
nicolasstucki
requested review from
OlivierBlanvillain
and removed request for
odersky
|
Found a cleaner solution with #2525 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes potential ways to fake evidences by casting an object that has a phantom type parameter/member. See
neg/phantom-class-type-parameters.scalaas an example.