Add expand/collapse to all sections of dottydoc #2489
Conversation
doc-tool/resources/css/api-page.css
Outdated
| @@ -142,3 +159,7 @@ div.entity-section > div.member > div.member-body > div.member-body-long { | |||
| div.entity-section > div.member > div.member-body > div.member-body-long.toggled { | |||
| display: block; | |||
| } | |||
|
|
|||
| div.entity-section.toggled{ | |||
| var members = document.getElementById("entity-members"); | ||
| members.classList.toggle("toggled"); | ||
| span.innerHTML = (span.innerHTML == "[-]") ? "[+]" : "[-]"; | ||
| } |
There was a problem hiding this comment.
This should be the same function - but perhaps taking the members variable as argument.
There was a problem hiding this comment.
I.e. toggleMembersBody and toggleConstructorsBody
There was a problem hiding this comment.
Got it! Will fix in the next commit. Is the edit with entities.scala acceptable?
There was a problem hiding this comment.
Yes - and it will be deleted soon anyway, right?
There was a problem hiding this comment.
Yeah, along with other stuff. Wanted to confirm with the deletion.
|
@felixmulder Removed instances of comment.short and changed a few CSS class names. Please comment your views and I'll fix the commit history to |
| currdate=$(date "+%Y-%m-%d\ %H:%M:%S") | ||
| currDateComment="<!-- Docs Last Generated On "$currdate"-->" | ||
| sed -i '.original' "1s/^/$currDateComment\\ | ||
| /" main.html |
There was a problem hiding this comment.
This script should probably not be included in the PR
There was a problem hiding this comment.
Yeah Sorry! Will fix it when I fix the commit history. Thanks!
|
Not by a computer currently, will test this tomorrow when I'm back at work, I want to see how it looks. Code looks fine otherwise! 👍 |
|
@felixmulder I think you'd have to revert that, courtesy rand.sh |
|
I was waiting for your final call so I'd fix up the commit messages and stuff. Sorry |
|
No worries, I squashed away the nastiness - this shouldn't be a full time job for you - you're a contributor :) |
Intended as a fix for #2211. This is a preliminary version (there's a lot of code to be deleted regarding the short-body part of Constructors/Members). Please do comment your views :)