Skip to content

[scaladays] dottydoc fixes 2 #2487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

felixmulder
Copy link
Contributor

This PR contains a bunch of fixes to dottydoc heading into ScalaDays. The beginnings of search will have to be enhanced - but this improves the state of things, quite a bit.

@felixmulder felixmulder requested a review from nicolasstucki May 20, 2017 16:25
@felixmulder
Copy link
Contributor Author

felixmulder commented May 20, 2017

Note that to be able to run this locally without disabling security features in the browser. Do the following:

$ sbt genDocs
$ cd docs/_site
$ python -m SimpleHTTPServer 8080

You can then browse the page at http://localhost:8080

Clarification: loading web-workers from scripts that are "above" you in the file-system is illegal, it is not, however, illegal if you're doing it across http. Makes sense, right?

@felixmulder felixmulder force-pushed the topic/dottydoc-scaladays-2k17-1 branch from c79f7b6 to 6b0df07 Compare May 22, 2017 07:46
@felixmulder
Copy link
Contributor Author

Preliminary reports from Stucki say this looks fine. I'm merging this now as it inhibits my progress and contains a bunch of useful fixes for the docs.

@felixmulder felixmulder merged commit d97d35d into scala:master May 22, 2017
@felixmulder felixmulder deleted the topic/dottydoc-scaladays-2k17-1 branch May 22, 2017 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant