Fix #1544: Allow long signatures in names #1588
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes scala#1544 by making the length field use 1 or 2 bytes, depending on the number of parameters in a signature.
odersky
changed the title
Closed
2 tasks
Blaisorblade
suggested changes
Oct 13, 2016
| op | ||
| val length = currentAddr.index - lengthAddr.index - 1 | ||
| assert(length < 128) | ||
| putNat(lengthAddr, length, 1) | ||
| putNat(lengthAddr, length, lengthWidth) |
There was a problem hiding this comment.
My only question is: what happens when the (altered) assertion fails? There can't be bounds-checking, so assert(length < (1 << (7 * lengthWidth))) would be good. I assume you're sure this will never happen, and that you're currently right, that's why I propose an assert, which would trigger if NameBuffer gets out-of-sync and lengthWidth is 1 when it shouldn't. Or simply if somebody forgets to specify lengthWidth 😉.
There was a problem hiding this comment.
There's already an assertion in NameBuffer that we don't overflow, and which even comes with a comprehensible error message. So we are good.
Blaisorblade
approved these changes
Oct 13, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1544 by making the length field use 1 or 2 bytes,
depending on the number of parameters in a signature.
Review by @Blaisorblade ?