Fix #1544: don't fail assertion in TastyPickler when signature is longer than 128 bytes #1572
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Blaisorblade
force-pushed
the
1544-extend-name-length
branch
2 times, most recently
from
550f697 to
08f6ce3
Compare
Blaisorblade
force-pushed
the
1544-extend-name-length
branch
from
08f6ce3 to
48a412e
Compare
odersky
reviewed
Oct 10, 2016
| @@ -42,11 +42,13 @@ class NameBuffer extends TastyBuffer(10000) { | |||
|
|
|||
| private def withLength(op: => Unit): Unit = { | |||
| val lengthAddr = currentAddr | |||
| writeByte(0) | |||
| val lengthFieldLength = 2 | |||
There was a problem hiding this comment.
A design goal of pickling is to be as compact as possible. Wasting one byte for each name is not compatible with that. We should find a scheme that needs the second byte only for long names. I would propose an optional parameter
def withLength(op: => Unit, maxLength: Int = 127)
which gets specialized in writeName.
|
Superseded by #1588. |
OlivierBlanvillain
pushed a commit
to OlivierBlanvillain/dotty
that referenced
this pull request
Dec 8, 2016
OlivierBlanvillain
pushed a commit
to OlivierBlanvillain/dotty
that referenced
this pull request
Dec 12, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1544 following suggestions there—this raises the maximum length field to 2^14. However, if this "fix prototype" fixes the immediate problem, I should probably replace the assertion by a proper error.
As implied there, the reading side appears to need no changes. Still only minimally tested.