Skip to content

Fix CI failure in [test_windows_full] (and publish Nightly) #11269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 1, 2021
Merged

Fix CI failure in [test_windows_full] (and publish Nightly) #11269

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
40b05e9
Fix CI failure in [test_windows_full]
nicolasstucki Feb 1, 2021
01537fc
Disable some scala3doc tests in Windows CI
nicolasstucki Feb 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions scala3doc/test/dotty/dokka/SignatureTest.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ abstract class SignatureTest(
filterFunc: (Path) => Boolean = _ => true
) extends ScaladocTest(testName):

def runTest = afterRendering {
def runTest = { org.junit.Assume.assumeTrue("Running on Windows", java.io.File.separatorChar == '/'); afterRendering {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will open an issue for this one

val sources = sourceFiles match
case Nil => testName :: Nil
case s => s
Expand Down Expand Up @@ -65,7 +65,7 @@ abstract class SignatureTest(
reportError(errorMessage)
end if

} :: Nil
} :: Nil }

// e.g. to remove '(0)' from object IAmACaseObject extends CaseImplementThis/*<-*/(0)/*->*/
private val commentRegex = raw"\/\*<-\*\/[^\/]+\/\*->\*\/".r
Expand Down
2 changes: 1 addition & 1 deletion tests/run-custom-args/tasty-inspector/tastyPaths.check
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
List(tastyPaths/I8163.class)
List(/tastyPaths/I8163.class)
`reflect.SourceFile.current` cannot be called within the TASTy ispector
4 changes: 3 additions & 1 deletion tests/run-custom-args/tasty-inspector/tastyPaths.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
import scala.quoted._
import scala.tasty.inspector._

import java.io.File.separatorChar

opaque type PhoneNumber = String

case class I8163() {
Expand All @@ -23,7 +25,7 @@ object Test {
class TestInspector() extends Inspector:

def inspect(using Quotes)(tastys: List[Tasty[quotes.type]]): Unit =
println(tastys.map(_.path.split("/tasty-inspector/").last))
println(tastys.map(_.path.split("tasty-inspector").last.replace(separatorChar, '/')))
try
quotes.reflect.SourceFile.current
assert(false)
Expand Down