Skip to content

Fix CI failure in [test_windows_full] (and publish Nightly) #11269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 1, 2021
Merged

Fix CI failure in [test_windows_full] (and publish Nightly) #11269

merged 2 commits into from
Feb 1, 2021

Conversation

nicolasstucki
Copy link
Contributor

[test_windows_full]

The failure had the following output

2021-02-01T03:26:04.6818405Z Output from 'tests\run-custom-args\tasty-inspector\tastyPaths.scala' did not match check file. Actual output:
2021-02-01T03:26:04.6953816Z List(C:\actions-runner\_work\dotty\dotty\out\runWithCompiler\tasty-inspector\tastyPaths\I8163.class)
2021-02-01T03:26:04.7340314Z `reflect.SourceFile.current` cannot be called within the TASTy ispector
2021-02-01T03:26:04.7542062Z 
2021-02-01T03:26:04.7837987Z 
2021-02-01T03:26:04.8059933Z Test output dumped in: tests\run-custom-args\tasty-inspector\tastyPaths.check.out
2021-02-01T03:26:04.8166294Z   See diff of the checkfile (`brew install icdiff` for colored diff)
2021-02-01T03:26:04.8369062Z     > diff tests\run-custom-args\tasty-inspector\tastyPaths.check tests\run-custom-args\tasty-inspector\tastyPaths.check.out
2021-02-01T03:26:04.8437054Z   Replace checkfile with current output
2021-02-01T03:26:04.8787235Z     > mv tests\run-custom-args\tasty-inspector\tastyPaths.check.out tests\run-custom-args\tasty-inspector\tastyPaths.check

https://github.com/lampepfl/dotty/runs/1803677061?check_suite_focus=true

@nicolasstucki nicolasstucki self-assigned this Feb 1, 2021
nicolasstucki
nicolasstucki commented Feb 1, 2021
View reviewed changes
scala3doc/test/dotty/dokka/SignatureTest.scala
@@ -22,7 +22,7 @@ abstract class SignatureTest(
filterFunc: (Path) => Boolean = _ => true
) extends ScaladocTest(testName):

def runTest = afterRendering {
def runTest = { org.junit.Assume.assumeTrue("Running on Windows", java.io.File.separatorChar == '/'); afterRendering {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will open an issue for this one

liufengyun
liufengyun approved these changes Feb 1, 2021
View reviewed changes
Copy link
Contributor

@liufengyun liufengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liufengyun liufengyun merged commit af15f6d into scala:master Feb 1, 2021
@liufengyun liufengyun deleted the fix-test_windows_full branch February 1, 2021 12:33
@nicolasstucki nicolasstucki mentioned this pull request Feb 1, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liufengyun liufengyun liufengyun approved these changes

Assignees

@liufengyun liufengyun

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nicolasstucki @liufengyun