Skip to content

Make owners explicit in reflection API #10406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 20, 2020

Conversation

nicolasstucki
Copy link
Contributor

@nicolasstucki nicolasstucki commented Nov 20, 2020

  • Make owners explicit in TreeMap, TreeTraverser and TreeAccumulator

This aligns the API design with Symbol.newXYZ, ValDef.let and Lambda.apply.

@nicolasstucki nicolasstucki force-pushed the make-owners-explicit branch 2 times, most recently from 749f302 to 1058bcb Compare November 20, 2020 12:32
@nicolasstucki nicolasstucki changed the title Make owners explicit Make owners explicit in reflection API Nov 20, 2020
* Make owners explicit in `TreeMap`, `TreeTraverser` and `TreeAccumulator`

This aligns the API design with `Symbol.newXYZ`, `ValDef.let` and `Lambda.apply`.
@nicolasstucki nicolasstucki added this to the 3.0.0-RC1 milestone Nov 20, 2020
@nicolasstucki nicolasstucki marked this pull request as ready for review November 20, 2020 16:18
Copy link
Contributor

@liufengyun liufengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nicolasstucki nicolasstucki merged commit d348877 into scala:master Nov 20, 2020
@nicolasstucki nicolasstucki deleted the make-owners-explicit branch November 20, 2020 18:12
@Kordyjan Kordyjan modified the milestones: 3.0.0-M3, 3.0.0 Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants