Remove old owner context from reflection API #10414
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasstucki
force-pushed
the
remove-old-owner-context
branch
2 times, most recently
from
5b3e0f3 to
eabb3c1
Compare
nicolasstucki
force-pushed
the
remove-old-owner-context
branch
from
eabb3c1 to
1f96b09
Compare
nicolasstucki
force-pushed
the
remove-old-owner-context
branch
from
1f96b09 to
89728ae
Compare
nicolasstucki
force-pushed
the
remove-old-owner-context
branch
from
89728ae to
a10a5f6
Compare
liufengyun
approved these changes
Nov 21, 2020
| @@ -66,7 +66,7 @@ trait SyntheticsSupport: | |||
| def hackGetAllMembers(using QuoteContext)(rsym: qctx.reflect.Symbol): List[qctx.reflect.Symbol] = { | |||
| import qctx.reflect._ | |||
| import dotty.tools.dotc | |||
| given ctx as dotc.core.Contexts.Context = rootContext.asInstanceOf | |||
| given ctx as dotc.core.Contexts.Context = qctx.asInstanceOf[scala.quoted.runtime.impl.QuoteContextImpl].ctx | |||
There was a problem hiding this comment.
Not sure why it needs the cast --- ideally APIs in scala.quote._ will be enough for usage, so that there is no need to use both reflect API and compiler API.
There was a problem hiding this comment.
This hacky method needs to be removed. Nobody should ever do this kind of cast.
There was a problem hiding this comment.
That is in the list of TODOs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This context does not carry any information.