Skip to content
This repository was archived by the owner on Sep 8, 2022. It is now read-only.

Extract useful things from ConsoleRunner and use them in SBTRunner #24

Closed
wants to merge 3 commits into from

Conversation

gourlaysama
Copy link
Contributor

The first commit just bumps dependency versions.

This splits ConsoleRunner in two: AbstractRunner contains most of the
behavior but doesn't assume (or at least less that before...) that we
are running from the command line. ConsoleRunner extends it to do the
same as before.

Now SBTRunner also extends AbstractRunner (instead of AntRunner), to
get support for --grep, --update-check, and all other options, for
testing an explicit file, and for pretty output.

This requires changes on the scala-partest-interface side too
(SBTRunner's public API has changed).

This splits ConsoleRunner in two: AbstractRunner contains most of the
behavior but doesn't assume (or at least less that before...) that we
are running from the command line. ConsoleRunner extends it to do the
same as before.

Now SBTRunner also extends AbstractRunner (instead of AntRunner), to
get support for --grep, --update-check, and all other options, for
testing an explicit file, and for pretty output.

This requires changes on the scala-partest-interface side too
(SBTRunner's public API has changed).
@gourlaysama
Copy link
Contributor Author

See scala/scala-partest-interface#5 for the corresponding changes and an what the result should look like

@@ -7,185 +7,23 @@ package scala.tools
package partest
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like 1000 line files, but I also prefer to avoid degenerate files. I would keep the runners together; maybe SbtRunner, too, since it's also trivial. This stuff has gone through refactoring with various file prefixes, DirectFoo, etc, etc. Runner.scala vacuumed up a lot and includes SuiteRunner, so I wouldn't know what to call this except Framework.scala.

@SethTisue
Copy link
Member

incorporated into, superseded by #40. (thank you, @gourlaysama!)

@SethTisue SethTisue closed this Nov 2, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants