This repository was archived by the owner on May 3, 2018. It is now read-only.
Pass down the TestFramework's arguments to SBTRunner #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This gives the TestFramework's arguments to SBTRunner in scala-partest, so that it can support the same input as the command line version. This assumes the necessary changes were done on the scala-partest side. With both this change and the one in scala-partest, "sbt-partest" is just as flexible as "ant-partest", using `testOnly`. For example: ``` sbt> testOnly -- files/pos/t6745.scala --update-check sbt> testOnly -- --show-diff pos scalacheck ``` (the leading `--` is necessary for now, sadly...)
|
See scala/scala-partest#24 for the corresponding changes in partest. |
| @@ -27,29 +27,8 @@ class Framework extends sbt.testing.Framework { | |||
| /** Represents one run of a suite of tests. | |||
| */ | |||
| case class Runner(args: Array[String], remoteArgs: Array[String], testClassLoader: ClassLoader) extends sbt.testing.Runner { | |||
| /** Returns an array of tasks that when executed will run tests and suites determined by the | |||
There was a problem hiding this comment.
Why docs got removed?
There was a problem hiding this comment.
Cutting off doc bit-rot at the source!
There was a problem hiding this comment.
The doc are just copy/pasted from https://github.com/sbt/test-interface/blob/master/src/main/java/sbt/testing/Runner.java
|
I only use sbt test on a small scale. But it's not obvious that the way to users' hearts is to use sbt test like partest. For instance, re-running with update-check or show-diff is not my favorite thing. |
4 tasks
|
@szeiger should we merge this? |
|
@SethTisue please do, it's required for scala/scala-partest#40 because the interface between scala-partest and scala-partest-interface changes |
SethTisue
added a commit
that referenced
this pull request
Nov 3, 2015
Pass down the TestFramework's arguments to SBTRunner
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gives the TestFramework's arguments to SBTRunner in
scala-partest, so that it can support the same input as the command line
version.
This assumes the necessary changes were done on the scala-partest side.
With both this change and the one in scala-partest, "sbt-partest" is
just as flexible as "ant-partest", using
testOnly. For example:(the leading
--is necessary for now, sadly...)