Skip to content

Online Intermediate Scala Public Enrollment #490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 17, 2016
Merged

Online Intermediate Scala Public Enrollment #490

merged 5 commits into from
Oct 17, 2016

Conversation

mslinn
Copy link
Contributor

@mslinn mslinn commented Oct 15, 2016

Our second public enrollment course!

@SethTisue
Copy link
Member

I tried this locally with bundle exec jekyll serve and when I click on the new event I get a 404 on http://0.0.0.0:4000/undefined

@mslinn
Copy link
Contributor Author

mslinn commented Oct 17, 2016

Sounds like a regression. Seems similar to issues #478 and #484

@SethTisue
Copy link
Member

hmm, for the October course it's broken locally but works on the real site. I don't know what to make of that. I guess I'll just merge this, and let's hope it works on the real site

@SethTisue SethTisue merged commit a46400b into scala:master Oct 17, 2016
@SethTisue
Copy link
Member

yeah, seems OK

@SethTisue
Copy link
Member

oh, except you forgot the category: event at the top. I supplied it in d727431

@mslinn
Copy link
Contributor Author

mslinn commented Oct 17, 2016

No, did not forget. For each of the events I posted I copied a previous event posting. None of them have a category entry. Also, the README.md file makes no mention of such a thing.

@mslinn
Copy link
Contributor Author

mslinn commented Oct 17, 2016

... but thank you!

@SethTisue
Copy link
Member

SethTisue commented Oct 17, 2016

None of them have a category entry

Your October event does. Remember #484?

the README.md file makes no mention of such a thing

Perhaps you are not viewing a current version? I'm looking at https://github.com/scala/scala-lang/blob/master/training/README.md right now and it's quite explicit about it. If we're not looking at the same thing, can you be more explicit about where you're looking?

@mslinn
Copy link
Contributor Author

mslinn commented Oct 17, 2016

Seems that was added to the docs 18 days ago, when Andy fixed the bug that prevented my previous course listing from working

@heathermiller
Copy link
Member

Sure. So it was in the README at the time you made this PR thanks to Andy's fix, no? Siding with Seth on this one.

In any case, the advertisement for your course is up, so all good on your side, right?

@mslinn
Copy link
Contributor Author

mslinn commented Oct 17, 2016

All good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants