Skip to content

Open Enrollment, Instructor-Led Online Introduction to Scala Course #478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 26, 2016
Merged

Conversation

mslinn
Copy link
Contributor

@mslinn mslinn commented Sep 26, 2016

No description provided.

title: Introduction to Scala Online
description: Hands-on course, scheduled over 30 days, 43 lectures, 8 hours of video, weekly office hours (videoconference), individual support
link-out: https://www.getscala.com/#live
where: Online, world-wide, office hours in multiple time zones
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shorten to just "online" else it will break the formatting. This field is not meant to wrap.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@heathermiller
Copy link
Member

Cool, thanks! LGTM :)

@heathermiller heathermiller merged commit 50abef9 into scala:master Sep 26, 2016
@mslinn
Copy link
Contributor Author

mslinn commented Sep 28, 2016

The training event is visible but the link is broken: http://scala-lang.org/undefined

@andy1138
Copy link
Contributor

@mslinn have you seen the scala-lang homepage. Main news headline is 'Introduction to Scala Online' , with a working like so not all bad :-)

I added a comment to the merge request, but I couldnt see whats wrong

@mslinn
Copy link
Contributor Author

mslinn commented Sep 28, 2016

Yes, I am reporting that the scala-lang home page shows the event, but the link is broken. The link I supplied was:

link-out: https://www.getscala.com/#live

Perhaps whatever parses the link threw an exception when it encountered the # character, hence the undefined.

@mslinn
Copy link
Contributor Author

mslinn commented Sep 28, 2016

Ouch!

@mslinn
Copy link
Contributor Author

mslinn commented Sep 28, 2016

I figured out a way to work within AWS redirection limitations. Instead of a # the URL now has a ?. Please reinstate this pull request. Hopefully the scala-lang site processor, whatever it is, will handle a query string better than it does anchors.

@andy1138
Copy link
Contributor

I've found the problem with external links. There is a 'bug' in the code and the url gets lost for training events. see: #481

There is another issue where training events is not being filtered from 'news' items. It can be fixed by adding 'category: event' to the PR. However I dont know if 'event' is "conference only" or "conf and training" will have to ask @heathermiller / @SethTisue / etc what it actually means

@mslinn
Copy link
Contributor Author

mslinn commented Sep 28, 2016

I wonder how the other training events worked, or was the bug recently introduced?

@andy1138
Copy link
Contributor

It looks like in Feb there was some work done on the website and yours is the first non-Typesafe/Lightbend training event to be added. (TS/LB have a special feed to auto add training sessions). This is when 'category: event' was added to the conf. events but looks like they missed/forgot training :-(

(see bottom of: f34dfd5 )

@heathermiller
Copy link
Member

Thanks @andy1138 for looking into it! Your help is much appreciated.

@heathermiller
Copy link
Member

heathermiller commented Sep 28, 2016

Ok, the proposed fix didn't work. I do not have time to debug this now, so in order to restore the frontpage of scala-lang to a functional state I'm reverting this pull request. If someone else has time to debug, I will happily merge!

Else, this will have to wait.

@soc
Copy link
Contributor

soc commented Sep 28, 2016

@mslinn Usually values with special characters require the whole value to be quoted, no need to change the URL scheme!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants