Skip to content

update Ruby to 2.5.8 (was 2.3.1) and nokogiri to 1.11.1 #1208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 27, 2021

Conversation

SethTisue
Copy link
Member

@SethTisue SethTisue commented Jan 26, 2021

@SethTisue
Copy link
Member Author

nokogiri-1.11.1-x86_64-linux requires ruby version < 3.1.dev, >= 2.5, which is
incompatible with the current version, ruby 2.3.1p112

I'm getting a feeling of deja vu, like this isn't the first time we've tried this :-/

@SethTisue SethTisue changed the title update nokogiri to 1.11.1 update Ruby to 2.5.8 (was 2.3.1) and nokogiri to 1.11.1 Jan 26, 2021
@SethTisue SethTisue requested a review from sjrd January 26, 2021 22:09
@sjrd
Copy link
Member

sjrd commented Jan 27, 2021

nokogiri-1.11.1-x86_64-linux requires ruby version < 3.1.dev, >= 2.5, which is
incompatible with the current version, ruby 2.3.1p112

I'm getting a feeling of deja vu, like this isn't the first time we've tried this :-/

I think we hadn't tried to upgrade Ruby, last time we encountered the issue.

@SethTisue SethTisue merged commit eafef88 into scala:master Jan 27, 2021
@SethTisue SethTisue deleted the nokogiri branch January 27, 2021 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants