Skip to content

update Ruby to 2.5.8 (was 2.3.1) and nokogiri to 1.11.1 #1909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 27, 2021
Merged

update Ruby to 2.5.8 (was 2.3.1) and nokogiri to 1.11.1 #1909

merged 2 commits into from
Jan 27, 2021

Conversation

SethTisue
Copy link
Member

@SethTisue SethTisue commented Jan 26, 2021

@SethTisue SethTisue changed the title update nokogiri to 1.11.1 update Ruby to 2.5.8 (was 2.3.1) and nokogiri to 1.11.1 Jan 26, 2021
@SethTisue SethTisue marked this pull request as draft January 26, 2021 22:09
@SethTisue
Copy link
Member Author

nokogiri-1.11.1-x86_64-linux requires ruby version < 3.1.dev, >= 2.5, which is
incompatible with the current version, ruby 2.3.1p112

@sjrd over at scala/scala-lang#1208 I was able to deal with this by bumping the Ruby version in .travis.yml, but in this repo we're on Drone with image: scalacenter/scala-rvm-jvm-coursier:2.0. What do you suggest we do?

  • have someone at the Center update the Drone setup
  • ditch Drone for Travis-CI or GitHub actions
    • context: the original Travis-to-Drone switch was made by Jorge at Add drone.yml and remove travis #685
    • I know Travis-CI but I don't know GitHub Actions, so if we go the Travis-CI route I'd be happy to just adapt the .travis.yml file we use over in the other repo, but if you want to go GitHub Actions instead, I'm not volunteering
  • shrug and kick the problem down the road

?

@sjrd
Copy link
Member

sjrd commented Jan 27, 2021

I'll put this up for discussion at the Center, and see if someone could take care of Drone or migrate to GitHub Actions. I don't think we should move anything to Travis at this point.

@vincenzobaz
Copy link
Contributor

I am working on migrating to Github Actions in this PR

@vincenzobaz
Copy link
Contributor

The ruby version is set in .github/workflows/build.yml, in theory changing Gemfile.lock and rebasing/merging on mastter shoud give you a green ci

@SethTisue SethTisue marked this pull request as ready for review January 27, 2021 16:03
@SethTisue SethTisue merged commit 8828d79 into scala:master Jan 27, 2021
@SethTisue SethTisue deleted the nokogiri branch January 27, 2021 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants