This repository was archived by the owner on Jun 23, 2020. It is now read-only.
Avoid deprecation/feature warnings #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This needs a (hopefully trivial) rebase as I've just merged #8. |
This commit adds -deprecation and -feature to scalacOptions and fix source code to avoid deprecation/feature warnings. Since scala#8 is already working on the usages of deprecated CompilationUnit, this commit does not fix them.
sumito3478
force-pushed
the
fix-warnings
branch
from
afe0151 to
d177b6f
Compare
Testing with 2.11.0-SNAPSHOT results "UNRESOLVED DEPENDENCIES".
|
@retronym Done, plus fixing the usages of deprecated CompilationUnit#warning (which is not fixed by #8), and updating sbt to 0.13.6. Since testing with 2.11.0-SNAPSHOT results "UNRESOLVED DEPENDENCIES" (I don't know when it started to fail - downgrading to sbt 0.13.5 doesn't help), I updated the scala version to 2.11.0 in .travis.yaml. |
|
2.11.0-SNAPSHOT was expunged from the Sonatype OSS snapshots repository. 2.11.0 is okay. An alternative would by 2.11.3-SNAPSHOT, but that will eventually run into the same problem. |
|
LGTM, thanks for your attention to detail. |
retronym
added a commit
that referenced
this pull request
Sep 16, 2014
Avoid deprecation/feature warnings
|
One thing I forgot to ask is for you to review and agree to our CLA: http://typesafe.com/contribute/cla/scala |
|
@retronym Done. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates scalaVersion to 2.11.2, sbt.version to 0.13.5, adds -deprecation and -feature to scalacOptions and fixes source code to avoid deprecation/feature warnings.
Since #8 is already working on the usages of deprecated CompilationUnit, this pull request does not fix them.