This repository was archived by the owner on Jun 23, 2020. It is now read-only.
Use context for error reporting. #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
My bad -- some of these run after typer of course. |
|
A nice illustration that we should use Reporter more uniformly, with typer.context's reporting buffering as needed. Currently, we don't have an abstraction for reporting errors both through global.reporter and typer.context... |
`unit.reporter` simply forwards to `global.reporter`, so use that one instead. Use `typer.context.error` where silent mode should be respected (i.e., during type checking).
sumito3478
added a commit
to sumito3478/scala-continuations
that referenced
this pull request
Sep 8, 2014
This commit adds -deprecation and -feature to scalacOptions and fix source code to avoid deprecation/feature warnings. Since scala#8 is already working on the usages of deprecated CompilationUnit, this commit does not fix them.
|
LGTM |
retronym
added a commit
that referenced
this pull request
Sep 16, 2014
Use context for error reporting.
sumito3478
added a commit
to sumito3478/scala-continuations
that referenced
this pull request
Sep 16, 2014
This commit adds -deprecation and -feature to scalacOptions and fix source code to avoid deprecation/feature warnings. Since scala#8 is already working on the usages of deprecated CompilationUnit, this commit does not fix them.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
unit.error is both deprecated and wrong during type checking, since it goes straight to the reporter, without considering silent mode
review by @retronym