Skip to content

Markdown port of new SIPs process #539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 12, 2016
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
294 changes: 256 additions & 38 deletions sips/sip-submission.md
Original file line number Diff line number Diff line change
@@ -1,61 +1,279 @@
---
layout: sip-landing
title: SIP Submission Process
title: SIP Specification and Submission
---

## How do I get started? ##
A **SIP** (_Scala Improvement Process_) is a process for submitting changes to
the Scala language. Its main motivation is to become the primary mechanism to
propose, discuss and implement language changes. In this process, all changes to
the language go through design documents, called Scala Improvement Proposals
(SIPs), which are openly discussed by a committee and only upon reaching a
consensus are accepted to be merged into the Scala compiler.

Before submitting a SIP, it is a good to float your proposal on [scala-debate](https://groups.google.com/forum/#!forum/scala-debate). Be specific and already draw up a document that contains all relevant details. Often, public discussions help to refine a proposal to a point where it can become a SIP.
The aim of the Scala Improvement Process is to apply the openness and
collaboration that have shaped Scala's documentation and implementation to the
process of evolving the language. This document captures our guidelines,
commitments and expectations regarding this process.

## How do I submit? ##
## Why write a SIP?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like to updated wording of this section!


The process to submit is simple:
SIPs are key to making Scala better for the good of everyone. If you decide to
invest the time and effort of putting a SIP forward and seeing it through, your
efforts and time will shape and improve the language, which means that your
proposal may impact the life of a myriad of developers all over the world,
including those on your own team. For many, this aspect alone can be quite
worthwhile.

* Fork the Scala documentation repository, [http://github.com/scala/scala.github.com](http://github.com/scala/scala.github.com).
* Create a new SIP file in the `sips/pending/_posts/`. Check the [Writing a SIP Tutorial](sip-tutorial.html)
* Make sure the new file follows the format: `YYYY-MM-dd-{title}.md`. Use the proposal date for `YYYY-MM-dd`.
* Use the [Markdown Syntax](http://daringfireball.net/projects/markdown/syntax) to write your SIP.
* Follow the instructions in the [README](https://github.com/scala/scala.github.com/blob/gh-pages/README.md) to build your SIP locally so you can ensure that it looks correct on the website.
* Create a link to your SIP in the "pending sips" section of `index.md`
* Commit your changes to your forked repository
* Create a new [pull request](https://github.com/scala/scala.github.com/pull/new/gh-pages). This will notify the Scala SIP team.
However, it's important to note that seeing a SIP through to its conclusion is
an involved task. On the one hand, it takes time to convince people that your
suggestions are a worthwhile change for hundreds of thousands of developers to
accept. Particularly given the sheer volume of developers that could be affected
by your SIP, SIP acceptance is conservative and carefully thought through.
Typically, this includes many rounds of discussion with core Scala maintainers
and the overall community, several iterations on the design of the SIP, and some
effort at prototyping the proposed change. Often, it takes months of discussion,
re-design, and prototyping for a SIP to be accepted and included in the Scala
compiler. It is, therefore important to note that seeing a SIP through to its
conclusion can be time-consuming and not all SIPs may end up in the Scala
compiler, although they may teach us all something!

If you’re motivated enough to go through this involved but rewarding process, go
on with writing and keep on reading.

## What's the process for submitting a SIP?

There are four major steps in the SIP process:

1. Initial informal discussion (2 weeks)
2. Submission
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about, for consistency reasons, we make this point also contain a time reference? E.g. (at the submitter's convenience)?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, but it will give the impression that the author has to meet a deadline (say, 1 month) when he doesn't, it's the Process Lead who does. If we add a time reference, then we should reword the title to 'Submission and Validation'.

3. Formal presentation (up to 1 month)
4. Formal evaluation (up to 6 months)

### Initial informal discussion (2 weeks)

Before submitting a SIP, it is required that you perform necessary preparations:

Discuss your idea on the Scala mailing lists (currently, we suggest
cross-posting on
[scala-sips](https://groups.google.com/forum/#!forum/scala-sips),
[scala-debate](https://groups.google.com/forum/#!forum/scala-debate), and
[scala-internals](https://groups.google.com/forum/#!forum/scala-internals). This
may change in the future.) Create a topic that starts with “Pre-SIP” and briefly
describe what you would like to change and why you think it’s a good idea.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about collapsing this one-element list into a non-bulleted paragraph?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done :)


Proposing your ideas on the mailing list is not an optional step. For every
change to the language, it is important to gauge interest from the compiler
maintainers and the community. Use this step to promote your idea and gather
early feedback on your informal proposal. It may happen that experts and
community members may have tried something similar in the past and may offer
valuable advice.

Within two weeks after your submission of the pre-SIP to the mailing list, the
Process Lead will intervene and advise you whether your idea can be submitted as
a SIP or needs more work.


### Submission
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comment about the title of this section above.


After receiving the green light from the Process Lead, you can write up your
idea and submit it as a SIP.

A SIP is a Markdown document written in conformance with the [process template](https://github.com/scala/slip/blob/master/slip-template.md).
It ought to contain a clear specification of the proposed changes. When such
changes significantly alter the compiler internals, the author is invited to
provide a proof of concept. Delivering a basic implementation can speed up the
process dramatically. Even compiler hackers find very difficult to predict the
interaction between the design and the implementation, so the sooner we have an
evidence of a working prototype that interacts with all the features in Scala,
the better. Otherwise, committee members may feel that the proposed changes are
impossible and automatically dismiss them. If your changes are big or somewhat
controversial, don’t let people hypothesize about them and show results upfront.

A SIP is submitted as a pull request against [the official Scala website
repo](https://github.com/scala/scala.github.com). Within a week of receiving the
pull request, the Process Lead will acknowledge your submission, validate it and
engage into some discussions with the author to improve the overall quality of
the document (if necessary).

When you and the Process Lead agree on the final document, it is formally
accepted for review: assigned a reviewer and scheduled for formal presentation.

### Formal presentation (up to 1 month)

During the next available SIP Committee meeting, the appointed reviewer presents
the SIP to the committee and kick starts the initial discussion.

If the Committee agrees that following through the SIP is a good idea, then the
following happens:

1. The SIP is assigned a number.
2. The SIP pull request is merged into the official Scala website repo, and the
merged document becomes the official webpage of the proposal.
3. An issue to discuss the SIP is opened at the official Scala website repo. Then,
the reviewer submits the initial feedback from the committee.
4. An implementation is requested (if not already present).

Otherwise, the SIP is rejected. The reviewer submits the collected feedback as a
comment to the pull request, and the pull request is closed.

### Formal evaluation (up to 6 iterations)

Evaluation of a SIP is done in iterations. The maximum number of iterations is
six. These iterations take place in the SIP meetings and are usually monthly.
However, they can last longer, in which case the author has more time to
implement all the required changes.

## What will happen next ##
The committee decides the duration of the next iteration depending upon the
feedback and complexity of the SIP. Consequently, authors have more time to
prepare all the changes. If they finish their revision before the scheduled
iteration, the Process Lead will reschedule it for the next available meeting.

The SIP committee will have a look at your proposal. If it is looks promising, it will be made into a SIP. At that point, you'll have to sign a CLA (contributor license agreement) which says that you are OK with the text of the proposal and the implementation being used in the Scala project.
During every iteration, the appointed reviewer presents the changes (updated
design document, progress with the implementation, etc) to the SIP Committee.
Based on the feedback, the SIP is either:

## What will happen afterwards ##
1. Accepted, in which case the committee will propose a release date to the
compiler maintainers, where the role of the committee ends.
2. Rejected, in which case the SIP is closed and no longer evaluated in the future.
3. Postponed, in which case the reviewer responds to the committee’s feedback in
the SIP issue tracker, and the SIP is scheduled for a follow-up discussion
during the next SIP meeting.

The SIP will get a unique number. It should be discussed on the [scala-sips mailing list](https://groups.google.com/forum/#!forum/scala-sips).
In these mails, every mail that is specific to a SIP ### should be prefixed with \[SIP-###\].
Typically, a SIP under discussion will have a member of the committee as shepherd, to help move it forward.
If no changes have been made to a SIP in two iterations, it’s marked as dormant
and both the PR and issue are closed. Dormant SIPs can be reopened by any
person, be it the same or different authors, at which point it will start from
the formal evaluation phase.

Before a SIP can be accepted, it also needs a full implementation that can be evaluated in practice.
That implementation can be done before the SIP is submitted, or else concurrently with the discussion period.
### Merging the proposal

## What is the provisional voting status? ##
If the SIP is accepted, the committee will propose a release date to the
compiler maintainers, where the role of the committee ends. Accepted SIPs will
then be merged under a flag. When SIPs introduce intricate changes and they
cannot be merged under a flag, the compiler maintainers will merge it directly.

When a release is drawing near, the SIP committee will hold on provisional vote on pending SIPs. This vote places sips in one of the current status:
## Structure of the process

* `Accepted` - The SIP will be included in the next release, pending an acceptable implementation.
* `Deferred - Next Meeting` - The committee has concerned that need to be addressed in the SIP before inclusion in the Release. If the concerns are handled before the next release, the SIP will be re-evaluated.
* `Delay - Next Release` - The SIP committee has larger concerns with the state of the SIP and would prefer to wait until the next Scala release to consider inclusion.
* `Not Accepted` - The SIP committee feels the SIP is not needed for the Scala language and turns down the proposal, with an explanation of why.
The SIP process involves the following parties:

## What happens for a Scala major release? ##
1. The SIP Authors
2. The Process lead
3. The SIP Committee

Before a Scala release, the committee will make a final decision for each SIP whether it should be accepted, rejected, or delayed for the next release. Accepted SIPs will be rolled into an upcoming Scala release and placed in the accepted folder. Rejected SIPs will be left in the SIP repository under the "rejected sips" section. Delayed SIPs will remain pending.
### The SIP Authors

Authors are responsible for building consensus within the community and
documenting dissenting opinions before the SIP is officially discussed by the
SIP committee. Their goal is to convince the committee that their proposal is
useful and addresses pertinent problems in the language as well as interactions
with already existing features. Authors can change over the lifecycle of the
SIP.

## Who is on the SIP committee ##
### The Process lead

Right Now:
The Process lead is the responsible of the smooth running of SIPs and SLIPs. He
or she appoints the committee members, calls the meetings monthly, assigns new
proposals to the members, and ensures that all of them are discussed within a
short period of time.

* Martin Odersky
* Josh Suereth
* Adriaan Moors
* Seth Tisue
* Dick Wall
* Heather Miller
### The SIP Committee

The SIP Committee is an experienced group of people with knowledge of the
compiler internals, responsible for the strategic direction of Scala. Members
are tasked with (a) communicating with the community, (b) weighing in pros and
cons of every proposal, and (c) accepting, postponing or rejecting the proposal.

Committee members should be either individuals responsible for a specific part
of the Scala codebase, committers or contributors of the Scala compiler.
Exceptionally, members may also be important representatives of the community
with a high technical knowledge to understand the implications of every proposal
and participate into the discussions. The members are elected by the Process
Lead based on their expertise and implication in the community.

The current committee members are:

- Martin Odersky ([@odersky](https://github.com/odersky)), EPFL
- Adriaan Moors ([@adriaanm](https://github.com/adriaanm)), Lightbend
- Erik Osheim ([@non](https://github.com/non)), independent
- Heather Miller ([@heathermiller](https://github.com/heathermiller)), Scala Center
- Seth Tisue ([@SethTisue](https://github.com/SethTisue)), Lightbend
- Sébastien Doeraene ([@sjrd](https://github.com/sjrd)), EPFL
- Eugene Burmako ([@xeno-by](https://github.com/xeno-by)), EPFL
- Andrew Marki ([@som-snytt](https://github.com/som-snytt)), independent
- Josh Suereth ([@jsuereth](https://github.com/jsuereth)), Google
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jsuereth I wonder if you would prefer “independent“ here, since you aren't really “representing” Google?


The current process lead is:

- Jorge Vicente Cantero ([@jvican](https://github.com/jvican)), Scala Center

### Reviewers

The Process Lead assigns every proposal to a member of the committee, which
becomes the reviewer. The main tasks of the reviewer are the following:

1. Discuss unclear points with the authors,
2. Help them address their issues and questions,
3. Provide them feedback from the discussions in the meetings, and
4. Explain the latest progress in every meeting.

### Voting

For a SIP to be accepted, it must fulfill two requirements:

- 70% of the committee votes in favor of it.
- Martin Odersky does not veto it.

### Responsibilities of the members

- Review the proposals they are assigned to. The process lead will always notify
them two weeks in advance, at minimum.
- Play a role in the discussions, learn in advance about the topic if needed, and
make up their mind in the voting process.
- Decide which utilities should be inside the core module and are required by the
compiler. The goal is to shrink it over time, and, where possible, move modules
to the platform, that will be managed by the SLIP process.

### Guests

Experts in some fields of the compiler may be invited to concrete meetings as
guests when discussing related SIPs. Their input would be important to discuss
the current state of the proposal, both its design and implementation.

## Proposal states

The state of a proposal changes over time depending on the phase of the process
and the decisions taken by the Committee. A given proposal can be in one of
several states:

1. **Validated:** The Process Lead has validated the proposal and checked that
meets all the formal requirements.
2. **Numbered:** The Committee agrees that the proposal is a valid document and
it’s worth considering it. Then, the Process Lead gives it a number.
3. **Awaiting review:** The proposal has been scheduled to be reviewed for a
concrete date.
4. **Under review:** Once the author has delivered a new version, the proposal will
be under review until the next available SIP meeting takes place.
5. **Under revision:** Authors are addressing the issues pinpointed by the
committee or working on the implementation.
6. **Dormant:** When a SIP has been under revision for more than two iterations (that
is, no progress has been made since the last review), it’s considered dormant,
in which case any related activity will be paralysed and the Process Lead will
not allocate more resources to it.
7. **Postponed:** The SIP has been postponed under some concrete conditions. When these
are met, the SIP can be resubmitted.
8. **Rejected:** The SIP has been rejected with a clear and full explanation.
9. **Accepted:** The SIP has been accepted and it’s waiting for the merge into the
Scala compiler.

## How do I submit? ##

The process to submit is simple:

* Fork the Scala documentation repository, [http://github.com/scala/scala.github.com](http://github.com/scala/scala.github.com).
* Create a new SIP file in the `sips/pending/_posts/`. Use the [S(L)IP template](https://github.com/scala/slip/blob/master/slip-template.md)
* Make sure the new file follows the format: `YYYY-MM-dd-{title}.md`. Use the proposal date for `YYYY-MM-dd`.
* Use the [Markdown Syntax](http://daringfireball.net/projects/markdown/syntax) to write your SIP.
* Follow the instructions in the [README](https://github.com/scala/scala.github.com/blob/gh-pages/README.md) to build your SIP locally so you can ensure that it looks correct on the website.
* Create a link to your SIP in the "pending sips" section of `index.md`
* Commit your changes to your forked repository
* Create a new [pull request](https://github.com/scala/scala.github.com/pull/new/gh-pages). This will notify the Scala SIP team.

We will ask new members to join from time to time. The committee decides collectively, but Martin reserves the final say if there is a disagreement.