Skip to content

Update to sjs-dom 2.0.0 #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 18, 2021
Merged

Conversation

armanbilge
Copy link
Member

Supersedes #30.

@djspiewak djspiewak merged commit 3949ce7 into scala-js:main Nov 18, 2021
@djspiewak
Copy link
Collaborator

@sjrd I'm assuming this means we need to bump to 2.0.0 here?

@armanbilge
Copy link
Member Author

No, this is only a test dependency :)

@djspiewak
Copy link
Collaborator

Oh, whew!

@sjrd
Copy link
Member

sjrd commented Nov 18, 2021

If it hadn't just been a test dependency, I wouldn't have let you introduce that dependency at all when I first reviewed. 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants