Skip to content

Update scalajs-dom to 2.0.0 #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

scala-steward
Copy link
Contributor

Updates org.scala-js:scalajs-dom from 1.2.0 to 2.0.0.
GitHub Release Notes - Version Diff

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.

Configure Scala Steward for your repository with a .scala-steward.conf file.

Have a fantastic day writing Scala!

Ignore future updates

Add this to your .scala-steward.conf file to ignore future updates of this dependency:

updates.ignore = [ { groupId = "org.scala-js", artifactId = "scalajs-dom" } ]

labels: library-update, semver-major

@sjrd
Copy link
Member

sjrd commented Oct 21, 2021

@scala-steward Could you please remove the .cross(CrossVersion.for3Use2_13) when you do this upgrade, or somehow warn users that they need to do that? This is very important for the ecosystem not to break down. See the release notes at https://github.com/scala-js/scala-js-dom/releases/tag/v2.0.0

@armanbilge
Copy link
Member

Yeah, I realized too late we should have coordinated with steward beforehand. I've been tracking updates since we released and manually intervening.
https://github.com/search?p=2&q=Update+scalajs-dom+to+2.0.0+author%3Ascala-steward+state%3Aopen&state=open&type=Issues

@@ -157,7 +157,7 @@ lazy val webworker = project
name := "scala-js-macrotask-executor-webworker",
scalaJSUseMainModuleInitializer := true,
libraryDependencies ++= Seq(
("org.scala-js" %%% "scalajs-dom" % "1.2.0").cross(CrossVersion.for3Use2_13),
("org.scala-js" %%% "scalajs-dom" % "2.0.0").cross(CrossVersion.for3Use2_13),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
("org.scala-js" %%% "scalajs-dom" % "2.0.0").cross(CrossVersion.for3Use2_13),
"org.scala-js" %%% "scalajs-dom" % "2.0.0",

@fthomas
Copy link

fthomas commented Oct 21, 2021

Could you please remove the .cross(CrossVersion.for3Use2_13) when you do this upgrade

I guess a Scalafix migration could have removed that. Unfortunately Scala Steward does not yet support migrations that target the build. I've opened scala-steward-org/scala-steward#2304 to track that.

@djspiewak djspiewak closed this Nov 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants