Skip to content

debug: add debug implementation for file-related structs #624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 2, 2023

Conversation

phip1611
Copy link
Member

@phip1611 phip1611 commented Jan 2, 2023

FileType, FileHandle, RegularFile, and Directory now implement Debug.

Checklist

  • Sensible git history (for example, squash "typo" or "fix" commits). See the Rewriting History guide for help.
  • Update the changelog (if necessary)

@phip1611
Copy link
Member Author

Are we good to go now? @nicholasbishop

CHANGELOG.md Outdated
@@ -53,6 +53,7 @@
- Added an `core::error::Error` implementation for `Error` to ease
integration with error-handling crates. (requires the **unstable** feature)
- Added partial support for the TCG protocols for TPM devices under `uefi::proto::tcg`.
- `FileType`, `FileHandle`, `RegularFile`, and `Directory` now implement `Debug`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like git rebased this to the wrong place -- it's under 0.19.0 instead of unreleased

Copy link
Member

@nicholasbishop nicholasbishop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than the changelog location

@phip1611 phip1611 merged commit 118afe7 into rust-osdev:main Mar 2, 2023
@phip1611 phip1611 deleted the debug-for-files branch March 12, 2023 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants