Merge pull request #624 from phip1611/debug-for-files

debug: add debug implementation for file-related structs

Author: phip1611

CHANGELOG.md

@@ -7,6 +7,7 @@
 - Added the `ComponentName1` and `ComponentName2` protocols. The `ComponentName`
   wrapper will automatically select `ComponentName2` if available, and fall back
   to `ComponentName1` otherwise.
+- `FileType`, `FileHandle`, `RegularFile`, and `Directory` now implement `Debug`.
 
 ### Changed
 

uefi/src/proto/media/file/dir.rs

@@ -13,6 +13,7 @@ use {alloc::alloc::Global, core::alloc::Allocator};
 /// addition to supporting the normal `File` operations, `Directory`
 /// supports iterating over its contained files.
 #[repr(transparent)]
+#[derive(Debug)]
 pub struct Directory(RegularFile);
 
 impl Directory {

uefi/src/proto/media/file/mod.rs

@@ -236,6 +236,7 @@ impl<T: File> FileInternal for T {}
 ///
 /// Dropping this structure will result in the file handle being closed.
 #[repr(transparent)]
+#[derive(Debug)]
 pub struct FileHandle(*mut FileImpl);
 
 impl FileHandle {
@@ -365,7 +366,8 @@ pub(super) struct FileImpl {
     flush: extern "efiapi" fn(this: &mut FileImpl) -> Status,
 }
 
-/// Disambiguates the file type. Returned by `File::into_type()`.
+/// Disambiguate the file type. Returned by `File::into_type()`.
+#[derive(Debug)]
 pub enum FileType {
     /// The file was a regular (data) file.
     Regular(RegularFile),

uefi/src/proto/media/file/regular.rs

@@ -7,11 +7,12 @@ use crate::{Result, Status};
 /// In addition to supporting the normal `File` operations, `RegularFile`
 /// supports direct reading and writing.
 #[repr(transparent)]
+#[derive(Debug)]
 pub struct RegularFile(FileHandle);
 
 impl RegularFile {
     /// A special position used to seek to the end of a file with `set_position()`.
-    pub const END_OF_FILE: u64 = core::u64::MAX;
+    pub const END_OF_FILE: u64 = u64::MAX;
 
     /// Coverts a `FileHandle` into a `RegularFile` without checking the file kind.
     /// # Safety