Skip to content

uefi: Consistently use &mut self for pxe::BaseCode methods #1566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 10, 2025
Merged

uefi: Consistently use &mut self for pxe::BaseCode methods #1566

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions uefi/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,9 @@
- **Breaking:** Removed `BootPolicyError` as `BootPolicy` construction is no
longer fallible. `BootPolicy` now tightly integrates the new `Boolean` type
of `uefi-raw`.
- **Breaking:** The `pxe::BaseCode::tftp_read_dir` and
`pxe::BaseCode::mtftp_read_dir` methods now take `&mut self` instead of
`&self`.
- `boot::memory_map()` will never return `Status::BUFFER_TOO_SMALL` from now on,
as this is considered a hard internal error where users can't do anything
about it anyway. It will panic instead.
Expand Down
4 changes: 2 additions & 2 deletions uefi/src/proto/network/pxe.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,7 +233,7 @@ impl BaseCode {

/// Reads a directory listing of a directory on a TFTP server.
pub fn tftp_read_dir<'a>(
&self,
&mut self,
server_ip: &IpAddress,
directory_name: &CStr8,
buffer: &'a mut [u8],
Expand Down Expand Up @@ -366,7 +366,7 @@ impl BaseCode {

/// Reads a directory listing of a directory on a MTFTP server.
pub fn mtftp_read_dir<'a>(
&self,
&mut self,
server_ip: &IpAddress,
buffer: &'a mut [u8],
info: &MtftpInfo,
Expand Down