Skip to content

uefi: Consistently use &mut self for pxe::BaseCode methods #1566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 10, 2025
Merged

uefi: Consistently use &mut self for pxe::BaseCode methods #1566

merged 1 commit into from
Mar 10, 2025

Conversation

nicholasbishop
Copy link
Member

Although these methods are just reading data, they are almost certainly modifying internal state in the UEFI protocol and so should be &mut.

Checklist

  • Sensible git history (for example, squash "typo" or "fix" commits). See the Rewriting History guide for help.
  • Update the changelog (if necessary)

@nicholasbishop
uefi: Consistently use &mut self for pxe::BaseCode methods
22604c7 
Although these methods are just reading data, they are almost certainly
modifying internal state in the UEFI protocol and so should be `&mut`.
phip1611
phip1611 approved these changes Mar 10, 2025
View reviewed changes
Copy link
Member

@phip1611 phip1611 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch

@phip1611 phip1611 added this pull request to the merge queue Mar 10, 2025
Merged via the queue into main with commit f6098f5 Mar 10, 2025
19 checks passed
@phip1611 phip1611 deleted the bishop-mut-pxe branch March 10, 2025 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phip1611 phip1611 phip1611 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nicholasbishop @phip1611