Clippy subtree update #142451

flip1995 · 2025-06-13T09:25:41Z

1 day late. Got distracted yesterday evening and forgot about it.

Looks for `TryFrom` implementations with uninhabited error types and suggests to implement `From` instead.

Keep the `P` constructor function for now, to minimize immediate churn. All the `into_inner` calls are removed, which is nice.

If an early return is found under the HIR local declaration node but before the child process is created, it should not trigger the lint because the child process has not yet been created.

Specifically `TyAlias`, `Enum`, `Struct`, `Union`. So the fields match the textual order in the source code. The interesting part of the change is in `compiler/rustc_hir/src/hir.rs`. The rest is extremely mechanical refactoring.

When determining when a function or method can be called from a `const` context, the determination must be made on the instance, not on the declaration. This makes a difference, for example, with `const_trait` traits whose implementations may or may not be `const`.

…atten, r=jhpratt Stabilize feature `result_flattening` Stabilizes the `Result::flatten` method ## Implementations - [x] Implementation `Result::flatten`: rust-lang#70140 - [x] Implementation `const` `Result::flatten`: rust-lang#130692 - [x] Update stabilization attribute macros (this PR) ## Stabilization process - [x] Created this PR [suggested](rust-lang#70142 (comment)) by ``@RalfJung`` - [x] FCP (haven't found any, is it applicable here?) - [ ] Close issue rust-lang#70142

I read a blog post about kernel security, and how various features might get lost while porting to Rust. In kernel C, they have some guardrails against divulging pointers. An easy way to replicate that in Rust is a lint for pointer formatting. So that's what this lint does. --- changelog: new [`pointer_format`] lint

In order to be consistent with our documentation, deprecated lints should not be counted when displaying the total number of lints on the [web site](https://rust-lang.github.io/rust-clippy/master/index.html). For example, as of 2025-06-01, there are 784 non-deprecated lints which are referred to as "over 750 lints" in the documentation, but the web site displays "Total number: 799". When one new lint will be added, there will be a discrepancy ("over 750 lints" vs. "Total number: 800") if this is not fixed.

changelog: none

@llogiq

In order to be consistent with our documentation, deprecated lints should not be counted when displaying the total number of lints on the [web site](https://rust-lang.github.io/rust-clippy/master/index.html). For example, as of 2025-06-01, there are 784 non-deprecated lints which are referred to as "over 750 lints" in the documentation, but the web site displays "Total number: 799". When one new lint will be added, there will be a discrepancy ("over 750 lints" vs. "Total number: 800") if this is not fixed. changelog: none r? @llogiq

rust-lang#14949) changelog: [update_lints]: replaced a smart quote

I find it much easier to think about in the positive sense.

…st-lang#14954) Closes rust-lang/rust-clippy#14926 changelog: [`semicolon_outside_block`] fix wrong suggestions when inside macros

`clippy_lints::casts::utils::int_ty_to_nbits` used to return `0` to indicate that the argument was not an integral type. It is more idiomatic to use `Option<u64>` as a return type.

Looks for `TryFrom` implementations with uninhabited error types and suggests to implement `From` instead. Fixes rust-lang/rust-clippy#2144 --- changelog: Add [`infallible_try_from`] lint

Closes rust-lang/rust-clippy#14857 changelog: [`unit_arg`] fix wrong suggestion for `Default::default`

Fixes: rust-lang/rust-clippy#14931 changelog: Fix [`manual_swap`]'s suggestion-causes-error when the variable is mutable or as loop variable.

So this is funny, the query `tcx.module_children` was top 3 in most time consuming functions in Clippy, it was being called 24384 times in tokio. "Unacceptable!" I thought. Digging a bit around, turns out that `clippy::strlen_on_c_strings` was calling for `get_def_path` via `match_libc_symbol`. This query pretty-prints things and performs some analysis. Yes, we were running early lint checks to see if symbols were from `libc`. I don't really trust callgrind when it says I've turn 81 billion instructions into like 10 million. So I benchmarked this the good ol' "compiling 20 times without incr" method and it went from 0.31s-0.45s to 0.25s constistently. (Profiled, and "benchmarked") on tokio.

So this is funny, the query `tcx.module_children` was top 3 in most time consuming functions in Clippy, it was being called 24384 times in tokio. "Unacceptable!" I thought. Digging a bit around, turns out that `clippy::strlen_on_c_strings` was calling for `get_def_path` via `match_libc_symbol`. This query pretty-prints things and performs some analysis. Yes, we were running early lint checks to see if symbols were from `libc`. I don't really trust callgrind when it says I've turn 81 billion instructions into like 10 million. So I benchmarked this the good ol' "compiling 20 times without incr" method and it went from 0.31s-0.45s to 0.25s constistently. (Profiled, and "benchmarked") on tokio. What I can get behind is via `strlen_on_c_strings` changing from 31 million instructions into 76k. 🎉 🥳 changelog: [`strlen_on_c_strings`]: Optimize it by 99.75%

@ghost

r? @ghost changelog: none

…ubtree-update

rustbot · 2025-06-13T09:25:48Z

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

rustbot · 2025-06-13T09:25:49Z

⚠️ Warning ⚠️

There are username mentions (such as @user) in the commit messages of the following commits.
Please remove the mentions to avoid spamming these users.
- 466e0fb
- eafef84
- c90c7c4
- b379d54
- 6d7c16a
- 4ef7529
There are issue links (such as #123) in the commit messages of the following commits.
Please move them to the PR description, to avoid spamming the issues with references to the commit, and so this bot can automatically canonicalize them to avoid issues with subtree.
- 1652187
- 3f48a2b
- 466e0fb
- a5a7eea
- 88bb8d1
- d7b27ec
- 6fa2866
- 9b8c42c
- 716eadf
- eafef84
- a4debd2
- 84ef7fb
- ed143af
- a76c2b3
- c90c7c4
- cf75dd4
- f8a3929
- 6ef2a2d
- b379d54
- da93448
- 6bb0c97
- f2922e7
- 33052be
- 0138c79
- a1a1393
- 737b8be
- 3af333e
- 9e7782b
- 6d7c16a
- ce8d263
- 180adb3
- 59d8345
- 6662aed
- 4ef7529

flip1995 · 2025-06-13T10:02:39Z

We're running clippy on bootstrap now 👀 that's good news. Now I have to figure out how to do that locally.

matthiaskrgr · 2025-06-13T10:17:47Z

maybe ./x.py clippy --stage 1 src/bootstrap

flip1995 · 2025-06-13T10:56:44Z

That's a FP: rust-lang/rust-clippy#15045

I moved the lint to nursery, as I think this is significant and a lot of people will encounter this.

flip1995 · 2025-06-13T10:57:52Z

maybe ./x.py clippy --stage 1 src/bootstrap

Thanks! That's it. As I have profile = "tools" in my bootstrap.toml for Clippy syncs, I left out the --stage 1 flag.

Manishearth · 2025-06-13T12:44:15Z

@bors r+ p=2 rollup=never

bors · 2025-06-13T12:44:18Z

📌 Commit 9cb0a64 has been approved by Manishearth

It is now in the queue for this repository.

bors · 2025-06-13T14:43:00Z

⌛ Testing commit 9cb0a64 with merge 0d6ab20...

bors · 2025-06-13T17:43:09Z

☀️ Test successful - checks-actions
Approved by: Manishearth
Pushing 0d6ab20 to master...

github-actions · 2025-06-13T17:45:53Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing c359117 (parent) -> 0d6ab20 (this PR)

Test differences

No test diffs found

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 0d6ab209c525e276cbe7544cbd39a3c3619b6b18 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

aarch64-apple: 6099.5s -> 4854.6s (-20.4%)
x86_64-apple-2: 5492.1s -> 4441.9s (-19.1%)
dist-apple-various: 6030.1s -> 7103.0s (17.8%)
x86_64-apple-1: 7083.2s -> 8260.5s (16.6%)
dist-x86_64-apple: 8252.3s -> 9531.4s (15.5%)
x86_64-rust-for-linux: 2935.5s -> 2547.4s (-13.2%)
i686-gnu-2: 6077.6s -> 5327.8s (-12.3%)
mingw-check-1: 1892.0s -> 1680.7s (-11.2%)
i686-gnu-nopt-1: 7988.3s -> 7120.0s (-10.9%)
x86_64-gnu-llvm-19-1: 3674.9s -> 3318.5s (-9.7%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2025-06-13T19:10:51Z

Finished benchmarking commit (0d6ab20): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.2%	[0.2%, 0.2%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results (secondary -0.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.3%	[2.3%, 2.3%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.4%	[-2.4%, -2.4%]	1
All ❌✅ (primary)	-	-	0

Cycles

Results (secondary -1.3%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	3.1%	[3.1%, 3.1%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-5.7%	[-5.7%, -5.7%]	1
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 755.253s -> 755.964s (0.09%)
Artifact size: 372.23 MiB -> 372.26 MiB (0.01%)

Alexendoo and others added 30 commits April 30, 2025 13:12

Remove ClippyCtfe pass

d49b8aa

Updated feature flag and output of clippy/tests/ui/map_flatten*

a9225f8

fix: unit_arg suggests wrongly for Default::default

0524773

fix: unit_arg wrongly handled macros

ebf39a5

Test that all interned symbols are referenced in Clippy sources

d82e51b

remove eq_unspanned from TokenStream

f6e5fa2

add lint infallible_try_from

8e581e3

Looks for `TryFrom` implementations with uninhabited error types and suggests to implement `From` instead.

Reduce P<T> to a typedef of Box<T>.

e177dd0

Keep the `P` constructor function for now, to minimize immediate churn. All the `into_inner` calls are removed, which is nice.

fix: branches_sharing_code suggests wrongly when dealing with macros

1c070ca

Remove incremental test, disable incremental for cargo tests

4f3d529

zombie_processes: do not complain about early early returns

3c8bfd1

If an early return is found under the HIR local declaration node but before the child process is created, it should not trigger the lint because the child process has not yet been created.

Reorder fields in hir::ItemKind variants.

459280c

Specifically `TyAlias`, `Enum`, `Struct`, `Union`. So the fields match the textual order in the source code. The interesting part of the change is in `compiler/rustc_hir/src/hir.rs`. The rest is extremely mechanical refactoring.

new restriction lint: pointer_format

e64dd8e

Merge commit '57cbadd68ac473bc50453f6b1320a02b68115f12'

9f86a57

Use interned symbols instead of strings in more places

3ed210c

Lint more cases in unit_arg

8029208

Use interned symbols instead of strings in more places (rust-lang#14855)

3f48a2b

changelog: none

chore: fix smart quote in comment used by update_lints script

89dc07a

chore: replace smart quote with straight quote in update_lints comment (

a5a7eea

rust-lang#14949) changelog: [update_lints]: replaced a smart quote

Invert the sense of is_not_macro_export.

abf5d4c

I find it much easier to think about in the positive sense.

fix: semicolon_outside_block suggests wrongly when inside macros

12fc6c7

Fix semicolon_outside_block suggests wrongly when inside macros (ru…

88bb8d1

…st-lang#14954) Closes rust-lang/rust-clippy#14926 changelog: [`semicolon_outside_block`] fix wrong suggestions when inside macros

fix: unnecessary_debug_formatting FP inside Debug impl

a4360d6

Use None::<u64> instead of 0 to denote an absence of value

225abd6

`clippy_lints::casts::utils::int_ty_to_nbits` used to return `0` to indicate that the argument was not an integral type. It is more idiomatic to use `Option<u64>` as a return type.

add lint infallible_try_from (rust-lang#14813)

d7b27ec

Looks for `TryFrom` implementations with uninhabited error types and suggests to implement `From` instead. Fixes rust-lang/rust-clippy#2144 --- changelog: Add [`infallible_try_from`] lint

samueltardieu and others added 8 commits June 12, 2025 23:21

Fix unit_arg suggests wrongly for Default::default (rust-lang#14881)

180adb3

Closes rust-lang/rust-clippy#14857 changelog: [`unit_arg`] fix wrong suggestion for `Default::default`

Fix suggestion-causes-error of manual_swap (rust-lang#14978)

59d8345

Fixes: rust-lang/rust-clippy#14931 changelog: Fix [`manual_swap`]'s suggestion-causes-error when the variable is mutable or as loop variable.

Merge remote-tracking branch 'upstream/master' into rustup

85655d4

Bump nightly version -> 2025-06-13

19c2f03

Rustup (rust-lang#15044)

4ef7529

r? @ghost changelog: none

Merge commit '4ef75291b5dd6739212f1f61666d19d4e086690d' into clippy-s…

8fe9c2c

…ubtree-update

rustbot assigned Manishearth Jun 13, 2025

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 13, 2025

This comment has been minimized.

Sign in to view

flip1995 mentioned this pull request Jun 13, 2025

coerce_container_to_any should not trigger in method chains rust-lang/rust-clippy#15045

Open

Move COERCE_CONTAINER_TO_ANY to nursery, as it has FPs

9cb0a64

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 13, 2025

bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 13, 2025

bors merged commit 0d6ab20 into rust-lang:master Jun 13, 2025
11 checks passed

rustbot added this to the 1.89.0 milestone Jun 13, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Clippy subtree update #142451

Clippy subtree update #142451

flip1995 commented Jun 13, 2025

Uh oh!

rustbot commented Jun 13, 2025

Uh oh!

rustbot commented Jun 13, 2025

Uh oh!

This comment has been minimized.

flip1995 commented Jun 13, 2025

Uh oh!

matthiaskrgr commented Jun 13, 2025

Uh oh!

flip1995 commented Jun 13, 2025

Uh oh!

flip1995 commented Jun 13, 2025

Uh oh!

Manishearth commented Jun 13, 2025

Uh oh!

bors commented Jun 13, 2025

Uh oh!

bors commented Jun 13, 2025

Uh oh!

bors commented Jun 13, 2025

Uh oh!

Uh oh!

github-actions bot commented Jun 13, 2025

Uh oh!

rust-timer commented Jun 13, 2025

Uh oh!

Uh oh!

Clippy subtree update #142451

Clippy subtree update #142451

Conversation

flip1995 commented Jun 13, 2025

Uh oh!

rustbot commented Jun 13, 2025

Uh oh!

rustbot commented Jun 13, 2025

Uh oh!

This comment has been minimized.

flip1995 commented Jun 13, 2025

Uh oh!

matthiaskrgr commented Jun 13, 2025

Uh oh!

flip1995 commented Jun 13, 2025

Uh oh!

flip1995 commented Jun 13, 2025

Uh oh!

Manishearth commented Jun 13, 2025

Uh oh!

bors commented Jun 13, 2025

Uh oh!

bors commented Jun 13, 2025

Uh oh!

bors commented Jun 13, 2025

Uh oh!

Uh oh!

github-actions bot commented Jun 13, 2025

Test differences

Job duration changes

Uh oh!

rust-timer commented Jun 13, 2025

Overall result: ❌ regressions - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Uh oh!