Skip to content

Stabilize feature result_flattening #141072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Rynibami
Copy link

@Rynibami Rynibami commented May 16, 2025

Stabilizes the Result::flatten method

Implementations

Stabilization process

@rustbot
Copy link
Collaborator

rustbot commented May 16, 2025

r? @jhpratt

rustbot has assigned @jhpratt.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels May 16, 2025
@rust-log-analyzer

This comment has been minimized.

@jhpratt
Copy link
Member

jhpratt commented May 16, 2025

Yes, FCP is necessary and will be done on this PR. There's nothing you need to do on that front.

@Rynibami Rynibami force-pushed the stabilize-const-result-flatten branch from 6fd9348 to 4c2d3bc Compare May 16, 2025 10:02
@rust-log-analyzer

This comment has been minimized.

@rustbot
Copy link
Collaborator

rustbot commented May 16, 2025

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

@RalfJung RalfJung added the I-libs-api-nominated Nominated for discussion during a libs-api team meeting. label May 16, 2025
#[unstable(feature = "result_flattening", issue = "70142")]
#[rustc_const_unstable(feature = "result_flattening", issue = "70142")]
#[stable(feature = "result_flattening", since = "CURRENT_RUSTC_VERSION")]
#[rustc_allow_const_fn_unstable(const_precise_live_drops)]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uses of this attribute should always be called out in the PR as they require special attention. However, this one should be fine, for the same reason as all the other rustc_allow_const_fn_unstable(const_precise_live_drops): if we change how const_precise_live_drops works, we'll ensure it keeps accepting these cases.

Cc @rust-lang/wg-const-eval

@Amanieu Amanieu added T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. and removed T-libs Relevant to the library team, which will review and decide on the PR/issue. I-libs-api-nominated Nominated for discussion during a libs-api team meeting. labels May 20, 2025
@Amanieu
Copy link
Member

Amanieu commented May 20, 2025

@rfcbot merge

@rfcbot
Copy link
Collaborator

rfcbot commented May 20, 2025

Team member @Amanieu has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@rfcbot rfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. and removed proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. labels May 20, 2025
@rfcbot
Copy link
Collaborator

rfcbot commented May 21, 2025

🔔 This is now entering its final comment period, as per the review above. 🔔

@jhpratt
Copy link
Member

jhpratt commented May 24, 2025

r=me with completed FCP

@rfcbot rfcbot added finished-final-comment-period The final comment period is finished for this PR / Issue. to-announce Announce this issue on triage meeting and removed final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. labels May 31, 2025
@rfcbot
Copy link
Collaborator

rfcbot commented May 31, 2025

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

This will be merged soon.

@jhpratt
Copy link
Member

jhpratt commented May 31, 2025

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented May 31, 2025

📌 Commit 48538ed has been approved by jhpratt

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. finished-final-comment-period The final comment period is finished for this PR / Issue. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. to-announce Announce this issue on triage meeting
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants