Skip to content

Add supported asm types for LoongArch32 #142248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add supported asm types for LoongArch32 #142248

wants to merge 1 commit into from

Conversation

heiher
Copy link
Contributor

@heiher heiher commented Jun 9, 2025

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 9, 2025
compiler-errors
compiler-errors reviewed Jun 9, 2025
View reviewed changes
compiler/rustc_target/src/asm/loongarch.rs Outdated
) -> &'static [(InlineAsmType, Option<Symbol>)] {
match self {
Self::reg => types! { _: I8, I16, I32, I64, F32, F64; },
Self::reg => {
if arch == InlineAsmArch::LoongArch64 {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we make this an exhaustive match?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

compiler-errors
compiler-errors reviewed Jun 9, 2025
View reviewed changes
src/doc/unstable-book/src/language-features/asm-experimental-arch.md
@@ -91,6 +91,8 @@ This feature tracks `asm!` and `global_asm!` support for the following architect
| CSKY | `freg` | None | `f32`, |
| SPARC | `reg` | None | `i8`, `i16`, `i32`, `i64` (SPARC64 only) |
| SPARC | `yreg` | N/A | Only clobbers |
| LoongArch32 | `reg` | None | `i8`, `i16`, `i32`, `f32` |
| LoongArch32 | `freg` | None | `f32`, `f64` |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code above reference LoongArch64 but this table doesn't. Is that a mistake?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also add LoongArch32 to the table above?

The code above reference LoongArch64 but this table doesn't. Is that a mistake?

LoongArch64 assembly is already stable. This PR adds it for LoongArch32.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

tgross35
tgross35 reviewed Jun 9, 2025
View reviewed changes
compiler/rustc_target/src/asm/loongarch.rs Outdated
Comment on lines 42 to 44
types! { _: I8, I16, I32, I64, F32, F64; }
} else {
types! { _: I8, I16, I32, F32; }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not something to do here, but as a note f16 could probably get allowed in GPRs at some point (maybe also fregs? Not sure what the ABI status is), cc #125398.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll submit a separate PR to add support for types like f16 for both LoongArch32 and LoongArch64.

@heiher heiher force-pushed the loong32-asm-types branch from 55cfa4b to 28c06c4 Compare June 10, 2025 03:19
Amanieu
Amanieu reviewed Jun 10, 2025
View reviewed changes
compiler/rustc_target/src/asm/loongarch.rs Outdated
(Self::reg, InlineAsmArch::LoongArch64) => types! { _: I8, I16, I32, I64, F32, F64; },
(Self::reg, InlineAsmArch::LoongArch32) => types! { _: I8, I16, I32, F32; },
(Self::freg, _) => types! { f: F32; d: F64; },
_ => unimplemented!("unsupported register class"),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be unreachable! instead of unimplemented!.

@heiher heiher force-pushed the loong32-asm-types branch from 28c06c4 to de8a91b Compare June 10, 2025 10:49
@Amanieu
Copy link
Member

Amanieu commented Jun 10, 2025

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jun 10, 2025

📌 Commit de8a91b has been approved by Amanieu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 10, 2025
fmease added a commit to fmease/rust that referenced this pull request Jun 10, 2025
@fmease
Rollup merge of rust-lang#142248 - heiher:loong32-asm-types, r=Amanieu
89a1c7a 
Add supported asm types for LoongArch32

r? `@Amanieu`
@fmease fmease mentioned this pull request Jun 10, 2025
Closed
bors added a commit that referenced this pull request Jun 11, 2025
@bors
Auto merge of #142313 - fmease:rollup-lktx4uz, r=fmease
114fc69 
Rollup of 13 pull requests

Successful merges:

 - #128425 (Make `missing_fragment_specifier` an unconditional error)
 - #141639 (Expose discriminant values in stable_mir)
 - #141967 (Configure bootstrap backport nominations through triagebot)
 - #142042 (Make E0621 missing lifetime suggestion verbose)
 - #142176 (tests: Split dont-shuffle-bswaps along opt-levels and arches)
 - #142235 (Build rustc with assertions in `dist-alt` jobs)
 - #142248 (Add supported asm types for LoongArch32)
 - #142272 (tests: Change ABIs in tests to more future-resilient ones)
 - #142282 (Only run `citool` tests on the `auto` branch)
 - #142285 (tests: Do not run afoul of asm.validity.non-exhaustive in input-stats)
 - #142297 (Implement `//@ needs-target-std` compiletest directive)
 - #142298 (Make loongarch-none target maintainers more easily pingable)
 - #142306 (Dont unwrap and re-wrap typing envs)

Failed merges:

 - #141942 (Implement representation options to smir)

r? `@ghost`
`@rustbot` modify labels: rollup
workingjubilee added a commit to workingjubilee/rustc that referenced this pull request Jun 11, 2025
@workingjubilee
Rollup merge of rust-lang#142248 - heiher:loong32-asm-types, r=Amanieu
9494235 
Add supported asm types for LoongArch32

r? ``@Amanieu``
@workingjubilee workingjubilee mentioned this pull request Jun 11, 2025
Closed
workingjubilee added a commit to workingjubilee/rustc that referenced this pull request Jun 11, 2025
@workingjubilee
Rollup merge of rust-lang#142248 - heiher:loong32-asm-types, r=Amanieu
74fbf92 
Add supported asm types for LoongArch32

r? ```@Amanieu```
@workingjubilee workingjubilee mentioned this pull request Jun 11, 2025
Closed
bors added a commit that referenced this pull request Jun 11, 2025
@bors
Auto merge of #142333 - workingjubilee:rollup-u4rvyvx, r=workingjubilee
cd7b2e0 
Rollup of 13 pull requests

Successful merges:

 - #134841 (Look at proc-macro attributes when encountering unknown attribute)
 - #141639 (Expose discriminant values in stable_mir)
 - #141967 (Configure bootstrap backport nominations through triagebot)
 - #142042 (Make E0621 missing lifetime suggestion verbose)
 - #142176 (tests: Split dont-shuffle-bswaps along opt-levels and arches)
 - #142248 (Add supported asm types for LoongArch32)
 - #142272 (tests: Change ABIs in tests to more future-resilient ones)
 - #142282 (Only run `citool` tests on the `auto` branch)
 - #142297 (Implement `//@ needs-target-std` compiletest directive)
 - #142298 (Make loongarch-none target maintainers more easily pingable)
 - #142306 (Dont unwrap and re-wrap typing envs)
 - #142324 (Remove unneeded `FunctionCx` from some codegen methods)
 - #142328 (feat: Add `bit_width` for unsigned integer types)

r? `@ghost`
`@rustbot` modify labels: rollup
workingjubilee added a commit to workingjubilee/rustc that referenced this pull request Jun 12, 2025
@workingjubilee
Rollup merge of rust-lang#142248 - heiher:loong32-asm-types, r=Amanieu
1be2954 
Add supported asm types for LoongArch32

r? ````@Amanieu````
@workingjubilee workingjubilee mentioned this pull request Jun 12, 2025
Closed
workingjubilee added a commit to workingjubilee/rustc that referenced this pull request Jun 12, 2025
@workingjubilee
Rollup merge of rust-lang#142248 - heiher:loong32-asm-types, r=Amanieu
b6bed38 
Add supported asm types for LoongArch32

r? `````@Amanieu`````
@workingjubilee workingjubilee mentioned this pull request Jun 12, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Amanieu Amanieu Amanieu left review comments

@compiler-errors compiler-errors compiler-errors left review comments

@tgross35 tgross35 tgross35 left review comments

Assignees

@Amanieu Amanieu

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@heiher @Amanieu @bors @compiler-errors @tgross35 @rustbot