Look at proc-macro attributes when encountering unknown attribute #134841

estebank · 2024-12-28T03:17:51Z

error: cannot find attribute `sede` in this scope
  --> $DIR/missing-derive-2.rs:22:7
   |
LL |     #[sede(untagged)]
   |       ^^^^
   |
help: the derive macros `Deserialize` and `Serialize` accept the similarly named `serde` attribute
   |
LL |     #[serde(untagged)]
   |         +

error: cannot find attribute `serde` in this scope
  --> $DIR/missing-derive-2.rs:16:7
   |
LL |     #[serde(untagged)]
   |       ^^^^^
   |
note: `serde` is imported here, but it is a crate, not an attribute
  --> $DIR/missing-derive-2.rs:5:1
   |
LL | extern crate serde;
   | ^^^^^^^^^^^^^^^^^^^
help: `serde` is an attribute that can be used by the derive macros `Serialize` and `Deserialize`, you might be missing a `derive` attribute
   |
LL + #[derive(Serialize, Deserialize)]
LL | enum B {
   |

Partially address #47608. This PR doesn't find macros that haven't yet been imported by name.

rustbot · 2024-12-28T03:17:59Z

r? @wesleywiser

rustbot has assigned @wesleywiser.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

compiler/rustc_resolve/src/diagnostics.rs

wesleywiser · 2025-06-09T15:34:33Z

@bors r+ rollup

bors · 2025-06-09T15:34:35Z

📌 Commit b2f9a3f has been approved by wesleywiser

It is now in the queue for this repository.

estebank · 2025-06-09T19:31:26Z

@bors r=wesleywiser

bors · 2025-06-09T19:31:29Z

📌 Commit 3ed1787 has been approved by wesleywiser

It is now in the queue for this repository.

Look at proc-macro attributes when encountering unknown attribute ``` error: cannot find attribute `sede` in this scope --> $DIR/missing-derive-2.rs:22:7 | LL | #[sede(untagged)] | ^^^^ | help: the derive macros `Deserialize` and `Serialize` accept the similarly named `serde` attribute | LL | #[serde(untagged)] | + error: cannot find attribute `serde` in this scope --> $DIR/missing-derive-2.rs:16:7 | LL | #[serde(untagged)] | ^^^^^ | note: `serde` is imported here, but it is a crate, not an attribute --> $DIR/missing-derive-2.rs:5:1 | LL | extern crate serde; | ^^^^^^^^^^^^^^^^^^^ help: `serde` is an attribute that can be used by the derive macros `Serialize` and `Deserialize`, you might be missing a `derive` attribute | LL + #[derive(Serialize, Deserialize)] LL | enum B { | ``` Partially address rust-lang#47608. This PR doesn't find [macros that haven't yet been imported by name](rust-lang@af945cb).

Rollup of 13 pull requests Successful merges: - #134442 (Specify the behavior of `file!`) - #134841 (Look at proc-macro attributes when encountering unknown attribute) - #140372 (Exhaustively handle parsed attributes in CheckAttr) - #140766 (Stabilize keylocker) - #141061 (Change __rust_no_alloc_shim_is_unstable to be a function) - #142042 (Make E0621 missing lifetime suggestion verbose) - #142101 (core::ptr: deduplicate more method docs) - #142176 (tests: Split dont-shuffle-bswaps along opt-levels and arches) - #142258 (platform-support.md: Mention specific Linux kernel version or later) - #142260 (Miri subtree update) - #142262 (Mark `core::slice::memchr` as `#[doc(hidden)]`) - #142272 (tests: Change ABIs in tests to more future-resilient ones) - #142275 (rustdoc: Refractor `clean_ty_generics`) r? `@ghost` `@rustbot` modify labels: rollup

Look at proc-macro attributes when encountering unknown attribute ``` error: cannot find attribute `sede` in this scope --> $DIR/missing-derive-2.rs:22:7 | LL | #[sede(untagged)] | ^^^^ | help: the derive macros `Deserialize` and `Serialize` accept the similarly named `serde` attribute | LL | #[serde(untagged)] | + error: cannot find attribute `serde` in this scope --> $DIR/missing-derive-2.rs:16:7 | LL | #[serde(untagged)] | ^^^^^ | note: `serde` is imported here, but it is a crate, not an attribute --> $DIR/missing-derive-2.rs:5:1 | LL | extern crate serde; | ^^^^^^^^^^^^^^^^^^^ help: `serde` is an attribute that can be used by the derive macros `Serialize` and `Deserialize`, you might be missing a `derive` attribute | LL + #[derive(Serialize, Deserialize)] LL | enum B { | ``` Partially address rust-lang#47608. This PR doesn't find [macros that haven't yet been imported by name](rust-lang@af945cb).

Rollup of 12 pull requests Successful merges: - #134442 (Specify the behavior of `file!`) - #134841 (Look at proc-macro attributes when encountering unknown attribute) - #140372 (Exhaustively handle parsed attributes in CheckAttr) - #140766 (Stabilize keylocker) - #141061 (Change __rust_no_alloc_shim_is_unstable to be a function) - #142042 (Make E0621 missing lifetime suggestion verbose) - #142101 (core::ptr: deduplicate more method docs) - #142258 (platform-support.md: Mention specific Linux kernel version or later) - #142260 (Miri subtree update) - #142262 (Mark `core::slice::memchr` as `#[doc(hidden)]`) - #142272 (tests: Change ABIs in tests to more future-resilient ones) - #142275 (rustdoc: Refractor `clean_ty_generics`) r? `@ghost` `@rustbot` modify labels: rollup

Look at proc-macro attributes when encountering unknown attribute ``` error: cannot find attribute `sede` in this scope --> $DIR/missing-derive-2.rs:22:7 | LL | #[sede(untagged)] | ^^^^ | help: the derive macros `Deserialize` and `Serialize` accept the similarly named `serde` attribute | LL | #[serde(untagged)] | + error: cannot find attribute `serde` in this scope --> $DIR/missing-derive-2.rs:16:7 | LL | #[serde(untagged)] | ^^^^^ | note: `serde` is imported here, but it is a crate, not an attribute --> $DIR/missing-derive-2.rs:5:1 | LL | extern crate serde; | ^^^^^^^^^^^^^^^^^^^ help: `serde` is an attribute that can be used by the derive macros `Serialize` and `Deserialize`, you might be missing a `derive` attribute | LL + #[derive(Serialize, Deserialize)] LL | enum B { | ``` Partially address rust-lang#47608. This PR doesn't find [macros that haven't yet been imported by name](rust-lang@af945cb).

Rollup of 14 pull requests Successful merges: - #134442 (Specify the behavior of `file!`) - #134841 (Look at proc-macro attributes when encountering unknown attribute) - #140372 (Exhaustively handle parsed attributes in CheckAttr) - #140766 (Stabilize keylocker) - #141642 (Note the version and PR of removed features when using it) - #141909 (Add central execution context to bootstrap) - #141992 (use `#[naked]` for `__rust_probestack`) - #142102 (docs: Small clarification on the usage of read_to_string and read_to_end trait methods) - #142124 (Allow transmute casts in pre-runtime-MIR) - #142240 (deduplicate the rest of AST walker functions) - #142258 (platform-support.md: Mention specific Linux kernel version or later) - #142262 (Mark `core::slice::memchr` as `#[doc(hidden)]`) - #142271 (compiler: fn ptrs should hit different lints based on ABI) - #142288 (const_eval: fix some outdated comments) r? `@ghost` `@rustbot` modify labels: rollup

fmease · 2025-06-10T14:51:24Z

Failed in rollup: #142290 (comment)
@bors r-

fmease · 2025-06-10T14:53:15Z

I've only briefly looked at the failure but I see a list of something changing order depending on the target (failure here is on dist-i586-gnu-i586-i686-musl), so this is likely query instability, e.g., iterating over a HashMap.

fmease · 2025-06-10T15:02:18Z

compiler/rustc_resolve/src/diagnostics.rs

+            // We didn't find an exact match. Look for close matches. If any, suggest fixing typo.
+            #[allow(rustc::potential_query_instability)] // We're immediately sorting these.
+            let mut all_attr_names: Vec<Symbol> = all_attrs.keys().cloned().collect();
+            all_attr_names.sort();


This doesn't do what you think it does and thus does actually result in query instability: The Ord impl for Symbol sorts by interning ID (which seems to be unstable). You instead want to sort by the string contents of the Symbol:

Suggested change

all_attr_names.sort();

all_attr_names.sort_by(|a, b| a.as_str().cmp(b.as_str()));

(pretty sure sort_by_key wouldn't work because the key wouldn't live long enough)

I don't actually know why we still have Ord impls for Symbol. IMO, we should have impl !Ord for Symbol {} impl !PartialOrd for Symbol {} but idk, maybe the query system or metadata encoding actually needs it to be Ord...

compiler/rustc_resolve/src/diagnostics.rs

``` error: cannot find attribute `empty_helper` in this scope --> $DIR/derive-helper-legacy-limits.rs:17:3 | LL | #[empty_helper] | ^^^^^^^^^^^^ | help: `empty_helper` is an attribute that can be used by the derive macro `Empty`, you might be missing a `derive` attribute | LL + #[derive(Empty)] LL | struct S2; | ``` Look at proc-macro attributes when encountering unknown attribute ``` error: cannot find attribute `sede` in this scope --> src/main.rs:18:7 | 18 | #[sede(untagged)] | ^^^^ | help: the derive macros `Serialize` and `Deserialize` accept the similarly named `serde` attribute | 18 | #[serde(untagged)] | ~~~~~ error: cannot find attribute `serde` in this scope --> src/main.rs:12:7 | 12 | #[serde(untagged)] | ^^^^^ | = note: `serde` is in scope, but it is a crate, not an attribute help: `serde` is an attribute that can be used by the derive macros `Serialize` and `Deserialize`, you might be missing a `derive` attribute | 10 | #[derive(Serialize, Deserialize)] | ```

estebank · 2025-06-10T23:47:43Z

@bors r=wesleywiser

bors · 2025-06-10T23:47:46Z

📌 Commit 1cc4d35 has been approved by wesleywiser

It is now in the queue for this repository.

Look at proc-macro attributes when encountering unknown attribute ``` error: cannot find attribute `sede` in this scope --> $DIR/missing-derive-2.rs:22:7 | LL | #[sede(untagged)] | ^^^^ | help: the derive macros `Deserialize` and `Serialize` accept the similarly named `serde` attribute | LL | #[serde(untagged)] | + error: cannot find attribute `serde` in this scope --> $DIR/missing-derive-2.rs:16:7 | LL | #[serde(untagged)] | ^^^^^ | note: `serde` is imported here, but it is a crate, not an attribute --> $DIR/missing-derive-2.rs:5:1 | LL | extern crate serde; | ^^^^^^^^^^^^^^^^^^^ help: `serde` is an attribute that can be used by the derive macros `Serialize` and `Deserialize`, you might be missing a `derive` attribute | LL + #[derive(Serialize, Deserialize)] LL | enum B { | ``` Partially address rust-lang#47608. This PR doesn't find [macros that haven't yet been imported by name](rust-lang@af945cb).

Rollup of 13 pull requests Successful merges: - #134841 (Look at proc-macro attributes when encountering unknown attribute) - #141639 (Expose discriminant values in stable_mir) - #141967 (Configure bootstrap backport nominations through triagebot) - #142042 (Make E0621 missing lifetime suggestion verbose) - #142176 (tests: Split dont-shuffle-bswaps along opt-levels and arches) - #142248 (Add supported asm types for LoongArch32) - #142272 (tests: Change ABIs in tests to more future-resilient ones) - #142282 (Only run `citool` tests on the `auto` branch) - #142297 (Implement `//@ needs-target-std` compiletest directive) - #142298 (Make loongarch-none target maintainers more easily pingable) - #142306 (Dont unwrap and re-wrap typing envs) - #142324 (Remove unneeded `FunctionCx` from some codegen methods) - #142328 (feat: Add `bit_width` for unsigned integer types) r? `@ghost` `@rustbot` modify labels: rollup

workingjubilee · 2025-06-11T08:26:13Z

seems it still has problems?

@bors r-

workingjubilee · 2025-06-11T08:26:19Z

#142333 (comment)

workingjubilee · 2025-06-11T08:46:41Z

@bors rollup=iffy

rustbot assigned wesleywiser Dec 28, 2024

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 28, 2024

This comment has been minimized.

Sign in to view

estebank force-pushed the serde-attr-4 branch from f88709b to 4a5ec26 Compare December 28, 2024 17:23

This comment was marked as resolved.

Sign in to view

estebank force-pushed the serde-attr-4 branch from 4a5ec26 to 291aaa9 Compare January 24, 2025 18:15

This comment has been minimized.

Sign in to view

This comment was marked as resolved.

Sign in to view

estebank force-pushed the serde-attr-4 branch from 21ea816 to b2f9a3f Compare March 9, 2025 20:17

This comment was marked as resolved.

Sign in to view

wesleywiser approved these changes Jun 6, 2025

View reviewed changes

compiler/rustc_resolve/src/diagnostics.rs Show resolved Hide resolved

wesleywiser approved these changes Jun 9, 2025

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 9, 2025

estebank force-pushed the serde-attr-4 branch from b2f9a3f to 3ed1787 Compare June 9, 2025 18:12

workingjubilee mentioned this pull request Jun 10, 2025

Rollup of 13 pull requests #142278

Closed

workingjubilee mentioned this pull request Jun 10, 2025

Rollup of 12 pull requests #142283

Closed

fmease mentioned this pull request Jun 10, 2025

Rollup of 14 pull requests #142290

Closed

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 10, 2025

fmease requested changes Jun 10, 2025

View reviewed changes

fmease reviewed Jun 10, 2025

View reviewed changes

compiler/rustc_resolve/src/diagnostics.rs Outdated Show resolved Hide resolved

estebank force-pushed the serde-attr-4 branch from 3ed1787 to 2e51aa6 Compare June 10, 2025 19:10

This comment has been minimized.

Sign in to view

estebank force-pushed the serde-attr-4 branch from 2e51aa6 to 1cc4d35 Compare June 10, 2025 21:48

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 10, 2025

workingjubilee mentioned this pull request Jun 11, 2025

Rollup of 17 pull requests #142332

Closed

workingjubilee mentioned this pull request Jun 11, 2025

Rollup of 13 pull requests #142333

Closed

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 11, 2025

	all_attr_names.sort();
	all_attr_names.sort_by(\|a, b\| a.as_str().cmp(b.as_str()));

Look at proc-macro attributes when encountering unknown attribute #134841

Are you sure you want to change the base?

Look at proc-macro attributes when encountering unknown attribute #134841

Conversation

estebank commented Dec 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Dec 28, 2024

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment was marked as resolved.

This comment has been minimized.

This comment was marked as resolved.

This comment was marked as resolved.

Uh oh!

wesleywiser commented Jun 9, 2025

Uh oh!

bors commented Jun 9, 2025

Uh oh!

estebank commented Jun 9, 2025

Uh oh!

bors commented Jun 9, 2025

Uh oh!

fmease commented Jun 10, 2025

Uh oh!

fmease commented Jun 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fmease Jun 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fmease Jun 10, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

This comment has been minimized.

estebank commented Jun 10, 2025

Uh oh!

bors commented Jun 10, 2025

Uh oh!

workingjubilee commented Jun 11, 2025

Uh oh!

workingjubilee commented Jun 11, 2025

Uh oh!

workingjubilee commented Jun 11, 2025

Uh oh!

Uh oh!

estebank commented Dec 28, 2024 •

edited

Loading

fmease commented Jun 10, 2025 •

edited

Loading

fmease Jun 10, 2025 •

edited

Loading