use #[naked] for __rust_probestack
#141992
Merged
+171
−275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-compiler-builtins
|
cc @tgross35 |
folkertdev
changed the title
#[naked] for __rust_probestack
|
It will most definitely work, in-tree compiler-builtins has no CI running and it is not yet used for anything :) |
|
Me and my impatience... Well, I'm happy to rebase this whenever to check whether things are working, and we'll see when everything is ready. |
|
☔ The latest upstream changes (presumably #142081) made this pull request unmergeable. Please resolve the merge conflicts. |
folkertdev
force-pushed
the
probestack-naked-function
branch
from
be86dc8 to
79aa400
Compare
rustbot
added
S-blocked
folkertdev
force-pushed
the
probestack-naked-function
branch
from
79aa400 to
6b6ad28
Compare
This comment has been minimized.
This comment has been minimized.
folkertdev
force-pushed
the
probestack-naked-function
branch
from
6b6ad28 to
a2da8e0
Compare
This comment has been minimized.
This comment has been minimized.
folkertdev
force-pushed
the
probestack-naked-function
branch
from
a2da8e0 to
601e479
Compare
|
I'll kick off some jobs that should cover fortanix/sgx/uefi @bors2 try |
|
@folkertdev can now perform try builds on this pull request |
rust-bors bot
added a commit
that referenced
this pull request
Jun 9, 2025
use `#[naked]` for `__rust_probestack` Let's see if this works now. Previously this change was in rust-lang/compiler-builtins#897, but we decided to wait until `compiler-builtins` was a subtree (and also `cfg(bootstrap)` is gone now). r? `@tgross35` cc `@bjorn3` try-job: `dist-various*` try-job: `test-various*`
tgross35
added
S-waiting-on-review
tgross35
reviewed
Jun 9, 2025
| // Our goal here is to touch each page between %rsp+8 and %rsp+8-%rax, | ||
| // ensuring that if any pages are unmapped we'll make a page fault. | ||
| // | ||
| // This function is unsafe because it uses a custom ABI, it does not actually match `extern "C"`. |
There was a problem hiding this comment.
Mind making these FIXME(extern_c) since that should be a thing soon?
tgross35
reviewed
Jun 9, 2025
tgross35
approved these changes
Jun 10, 2025
|
@bors delegate+ |
|
✌️ @folkertdev, you can now approve this pull request! If @tgross35 told you to " |
folkertdev
force-pushed
the
probestack-naked-function
branch
from
fff42eb to
b030442
Compare
bors
added
S-waiting-on-bors
fmease
added a commit
to fmease/rust
that referenced
this pull request
Jun 10, 2025
…on, r=tgross35 use `#[naked]` for `__rust_probestack` Let's see if this works now. Previously this change was in rust-lang/compiler-builtins#897, but we decided to wait until `compiler-builtins` was a subtree (and also `cfg(bootstrap)` is gone now). r? `@tgross35` cc `@bjorn3` try-job: `dist-various*` try-job: `test-various*`
bors
added a commit
that referenced
this pull request
Jun 10, 2025
Rollup of 14 pull requests Successful merges: - #134442 (Specify the behavior of `file!`) - #134841 (Look at proc-macro attributes when encountering unknown attribute) - #140372 (Exhaustively handle parsed attributes in CheckAttr) - #140766 (Stabilize keylocker) - #141642 (Note the version and PR of removed features when using it) - #141909 (Add central execution context to bootstrap) - #141992 (use `#[naked]` for `__rust_probestack`) - #142102 (docs: Small clarification on the usage of read_to_string and read_to_end trait methods) - #142124 (Allow transmute casts in pre-runtime-MIR) - #142240 (deduplicate the rest of AST walker functions) - #142258 (platform-support.md: Mention specific Linux kernel version or later) - #142262 (Mark `core::slice::memchr` as `#[doc(hidden)]`) - #142271 (compiler: fn ptrs should hit different lints based on ABI) - #142288 (const_eval: fix some outdated comments) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
that referenced
this pull request
Jun 10, 2025
Rollup of 16 pull requests Successful merges: - #134442 (Specify the behavior of `file!`) - #140372 (Exhaustively handle parsed attributes in CheckAttr) - #140766 (Stabilize keylocker) - #141642 (Note the version and PR of removed features when using it) - #141818 (Don't create .msi installer for gnullvm hosts) - #141909 (Add central execution context to bootstrap) - #141992 (use `#[naked]` for `__rust_probestack`) - #142101 (core::ptr: deduplicate more method docs) - #142102 (docs: Small clarification on the usage of read_to_string and read_to_end trait methods) - #142124 (Allow transmute casts in pre-runtime-MIR) - #142240 (deduplicate the rest of AST walker functions) - #142258 (platform-support.md: Mention specific Linux kernel version or later) - #142262 (Mark `core::slice::memchr` as `#[doc(hidden)]`) - #142271 (compiler: fn ptrs should hit different lints based on ABI) - #142275 (rustdoc: Refractor `clean_ty_generics`) - #142288 (const_eval: fix some outdated comments) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
that referenced
this pull request
Jun 10, 2025
Rollup merge of #141992 - folkertdev:probestack-naked-function, r=tgross35 use `#[naked]` for `__rust_probestack` Let's see if this works now. Previously this change was in rust-lang/compiler-builtins#897, but we decided to wait until `compiler-builtins` was a subtree (and also `cfg(bootstrap)` is gone now). r? ``@tgross35`` cc ``@bjorn3`` try-job: `dist-various*` try-job: `test-various*`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's see if this works now.
Previously this change was in rust-lang/compiler-builtins#897, but we decided to wait until
compiler-builtinswas a subtree (and alsocfg(bootstrap)is gone now).r? @tgross35 cc @bjorn3
try-job:
dist-various*try-job:
test-various*