Rollup of 8 pull requests #141662
Merged
Rollup of 8 pull requests #141662
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
try_lock() and try_lock_shared() do not need to handle these per the discussion in rust-lang#140718 (comment)
This makes error propagation from try_lock() and try_lock_shared() more convenient
doesn't look like anyone is using it.
else it breaks with `rpath=false`. Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
…changes with `A-LLVM`
Add From<TryLockError> for io::Error Adds a `From` impl to make error propagation easier, as discussed in the tracking issue `TryLockError` is unstable under the "file_lock" feature. The related tracking issue is rust-lang#130994 This PR also cleanups the Windows implementation of `try_lock()` and `try_lock_shared()` as [discussed here](rust-lang#140718 (comment))
…mease
Rename `{GenericArg,Term}::unpack()` to `kind()`
A well-deserved rename IMO.
r? `@oli-obk` or `@lcnr` (or anyone)
cc `@rust-lang/types,` but I'd be surprised if this is controversial.
triagebot: label LLVM submodule changes with `A-LLVM` Fixes rust-lang#141601. r? `@apiraino`
…l, r=oli-obk remove `visit_mt` from `ast::mut_visit` doesn't look like anyone is using it.
…n-check-rpath-false, r=jieyouxu test: convert version_check ui test to run-make else it breaks with `rpath=false`. Fixes: rust-lang#141579
bump fluent-* crates This bumps fluent-* crates, switching to more up-to-date deps, reducing number of old ones. changelogs is pure refactoring: https://github.com/projectfluent/fluent-rs/blob/fluent-bundle%400.16.0/fluent-bundle/CHANGELOG.md https://github.com/projectfluent/fluent-rs/blob/fluent-bundle%400.16.0/fluent-syntax/CHANGELOG.md
… r=Zalathar coverage: Revert "unused local file IDs" due to empty function names The changes to coverage metadata generation in rust-lang#140847 appear to be the most likely cause of the `function name is empty` errors reported in rust-lang#141577. If that guess is correct, great. If not, no big deal. --- This reverts commit 3b22c21, reversing changes made to 5f292ee. r? ghost
…youxu tests: mark option-niche-eq as fixed on LLVM 21 Some combination of recent Rust changes (between 3d86494 and aa57e46 from what I can tell) and changes in LLVM 21 (not recently, as best I can tell) have caused this test to start showing the behavior we want, so it's time to move this test to a proper place and mark it as fixed on LLVM 21. ~~Probably "fixes" rust-lang#49892, but I'll let others make that call.~~ Closes rust-lang#49892 unless we want to break out a dedicated issue for `Option<bool>::eq` on LLVM 20 (seems low-value). `@rustbot` label llvm-main
rustbot
added
A-meta
|
@bors r+ rollup=never p=5 |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
📌 Perf builds for each rolled up PR:
previous master: c583fa6d84 In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing c583fa6 (parent) -> 45f256d (this PR) Test differencesShow 292 test diffsStage 1
Stage 2
Additionally, 264 doctest diffs were found. These are ignored, as they are noisy. Job group index
Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 45f256d9d7cffb66185c0bf1b8a864cba79db90c --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
|
Finished benchmarking commit (45f256d): comparison URL. Overall result: ✅ improvements - no action needed@rustbot label: -perf-regression Instruction countThis is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.
Max RSS (memory usage)Results (secondary 1.7%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResults (primary 2.8%, secondary -3.0%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 779.145s -> 779.523s (0.05%) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
{GenericArg,Term}::unpack()tokind()#141495 (Rename{GenericArg,Term}::unpack()tokind())A-LLVM#141602 (triagebot: label LLVM submodule changes withA-LLVM)visit_mtfromast::mut_visit#141632 (removevisit_mtfromast::mut_visit)Failed merges:
visit_clobberand moveDummyAstNodetorustc_expand#141430 (removevisit_clobberand moveDummyAstNodetorustc_expand)&mut P<T>in AST visitors #141636 (avoid some usages of&mut P<T>in AST visitors)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup