Change File::try_lock() and try_lock_shared() to return io::Result<()> #140718
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
6 tasks
Amanieu
reviewed
May 6, 2025
|
This looks good to me, pending the question about Windows. |
|
I think the question about Windows has been resolved now. |
Amanieu
reviewed
May 20, 2025
try_lock() and try_lock_shared() do not need to handle these per the discussion in rust-lang#140718 (comment)
cberner
added a commit
to cberner/rust
that referenced
this pull request
May 20, 2025
try_lock() and try_lock_shared() do not need to handle these per the discussion in rust-lang#140718 (comment)
cberner
added a commit
to cberner/rust
that referenced
this pull request
May 20, 2025
try_lock() and try_lock_shared() do not need to handle these per the discussion in rust-lang#140718 (comment)
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
May 27, 2025
Add From<TryLockError> for io::Error Adds a `From` impl to make error propagation easier, as discussed in the tracking issue `TryLockError` is unstable under the "file_lock" feature. The related tracking issue is rust-lang#130994 This PR also cleanups the Windows implementation of `try_lock()` and `try_lock_shared()` as [discussed here](rust-lang#140718 (comment))
rust-timer
added a commit
that referenced
this pull request
May 27, 2025
Rollup merge of #141312 - cberner:filelock_from, r=joshtriplett Add From<TryLockError> for io::Error Adds a `From` impl to make error propagation easier, as discussed in the tracking issue `TryLockError` is unstable under the "file_lock" feature. The related tracking issue is #130994 This PR also cleanups the Windows implementation of `try_lock()` and `try_lock_shared()` as [discussed here](#140718 (comment))
|
Closing since the libs-api team decided to stay with the previous API in the end. |
github-actions bot
pushed a commit
to rust-lang/miri
that referenced
this pull request
May 28, 2025
Add From<TryLockError> for io::Error Adds a `From` impl to make error propagation easier, as discussed in the tracking issue `TryLockError` is unstable under the "file_lock" feature. The related tracking issue is rust-lang/rust#130994 This PR also cleanups the Windows implementation of `try_lock()` and `try_lock_shared()` as [discussed here](rust-lang/rust#140718 (comment))
github-actions bot
pushed a commit
to model-checking/verify-rust-std
that referenced
this pull request
May 30, 2025
try_lock() and try_lock_shared() do not need to handle these per the discussion in rust-lang#140718 (comment)
github-actions bot
pushed a commit
to model-checking/verify-rust-std
that referenced
this pull request
May 30, 2025
Add From<TryLockError> for io::Error Adds a `From` impl to make error propagation easier, as discussed in the tracking issue `TryLockError` is unstable under the "file_lock" feature. The related tracking issue is rust-lang#130994 This PR also cleanups the Windows implementation of `try_lock()` and `try_lock_shared()` as [discussed here](rust-lang#140718 (comment))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the signatures of
File::try_lockandFile::try_lock_sharedas requested by @rust-lang/libs-api in this discussion: #130994 (comment)These methods are unstable under the "file_lock" feature. The related tracking issue is #130994