Skip to content

Move dist-x86_64-linux CI job to GitHub temporarily #141388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 22, 2025
Merged

Move dist-x86_64-linux CI job to GitHub temporarily #141388

merged 1 commit into from
May 22, 2025

Conversation

Kobzol
Copy link
Contributor

@Kobzol Kobzol commented May 22, 2025

To make it easier to migrate off the rust-lang-ci/rust repository.

r? @marcoieni

@Kobzol
Move dist-x86_64-linux CI job to GitHub temporarily
7d32303 
To make it easier to migrate off the `rust-lang-ci/rust` repository.
@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels May 22, 2025
@marcoieni
Copy link
Member

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented May 22, 2025

📌 Commit 7d32303 has been approved by marcoieni

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 22, 2025
@marcoieni marcoieni mentioned this pull request May 22, 2025
Open
29 tasks
@jieyouxu
Copy link
Member

Probably don't want this in a rollup, might affect job timings?

@bors rollup=never

@Kobzol
Copy link
Contributor Author

Kobzol commented May 22, 2025 •
edited
Loading

What timings do you have in mind? I think I haven't ever seen this job being in the top 10 changes in the post merge analysis. I think that's fine.

Also I'd like to get this merge soon-ish 😅 Bumping this to move forward with the rust-lang-ci migration, because in the meantime, our CI is slower (due to moving off from codebuild and not allowing Docker cache reuse on PR CI builds).

@bors p=5 rollup

@jieyouxu
Copy link
Member

That is true

@jieyouxu
Copy link
Member

If it's time-sensitive, I'd just bump it higher.

@bors p=10

@bors
Copy link
Collaborator

bors commented May 22, 2025

⌛ Testing commit 7d32303 with merge 2eef478...

@bors
Copy link
Collaborator

bors commented May 22, 2025

☀️ Test successful - checks-actions
Approved by: marcoieni
Pushing 2eef478 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label May 22, 2025
@bors bors merged commit 2eef478 into rust-lang:master May 22, 2025
7 checks passed
@rustbot rustbot added this to the 1.89.0 milestone May 22, 2025
@github-actions GitHub Actions
Copy link

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing e3892a4 (parent) -> 2eef478 (this PR)

Test differences

No test diffs found

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 2eef47813f25df637026ce3288880e5c587abd92 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. x86_64-apple-2: 5096.3s -> 7138.2s (40.1%)
  2. dist-apple-various: 5649.7s -> 7895.0s (39.7%)
  3. dist-x86_64-apple: 8682.8s -> 9759.0s (12.4%)
  4. x86_64-gnu-llvm-20-1: 5650.5s -> 5106.9s (-9.6%)
  5. x86_64-gnu-llvm-19-1: 5633.6s -> 5173.0s (-8.2%)
  6. x86_64-apple-1: 7857.7s -> 8445.5s (7.5%)
  7. x86_64-gnu-tools: 5652.8s -> 6055.2s (7.1%)
  8. dist-x86_64-linux: 5091.3s -> 5451.5s (7.1%)
  9. dist-various-2: 3334.9s -> 3161.4s (-5.2%)
  10. dist-i586-gnu-i586-i686-musl: 5260.9s -> 5494.2s (4.4%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (2eef478): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 776.4s -> 776.347s (-0.01%)
Artifact size: 365.61 MiB -> 365.46 MiB (-0.04%)

@Kobzol Kobzol deleted the x64-github-runner branch May 23, 2025 05:59
@marcoieni marcoieni mentioned this pull request May 24, 2025
Open
@cuviper cuviper mentioned this pull request May 24, 2025
Merged
@cuviper cuviper added the beta-accepted Accepted for backporting to the compiler in the beta channel. label May 24, 2025
@cuviper cuviper modified the milestones: 1.89.0, 1.88.0 May 24, 2025
bors added a commit that referenced this pull request May 24, 2025
@bors
Auto merge of #141412 - cuviper:beta-next, r=cuviper
ae02e44 
[beta] backports and stage0 bump

- bump stage0 to 1.87.0
- Update the edition guide for let chains #140852
- Fix download of GCC from CI on non-nightly channels #140901
- Revert "Fix linking statics on Arm64EC #140176" #141024
- [win][arm64] Remove 'Arm64 Hazard' undocumented MSVC option and instead disable problematic test #141045
- Do not call name() on rpitit assoc_item #141308
- Temporarily use Windows Server 2022 instead of Windows Server 2025 images #141023
- Use Docker cache from the current repository #141280
- Move dist-x86_64-linux CI job to GitHub temporarily #141388
- ci: prepare aws access keys for migration #141389

r? cuviper
bors added a commit that referenced this pull request May 25, 2025
@bors
Auto merge of #141412 - cuviper:beta-next, r=Mark-Simulacrum
4330d60 
[beta] backports and stage0 bump

- bump stage0 to 1.87.0
- Update the edition guide for let chains #140852
- Fix download of GCC from CI on non-nightly channels #140901
- Revert "Fix linking statics on Arm64EC #140176" #141024
- [win][arm64] Remove 'Arm64 Hazard' undocumented MSVC option and instead disable problematic test #141045
- Do not call name() on rpitit assoc_item #141308
- Temporarily use Windows Server 2022 instead of Windows Server 2025 images #141023
- Use Docker cache from the current repository #141280
- Move dist-x86_64-linux CI job to GitHub temporarily #141388
- ci: prepare aws access keys for migration #141389
- Add bors environment to CI #141323

r? cuviper
bors added a commit that referenced this pull request May 25, 2025
@bors
Auto merge of #141412 - cuviper:beta-next, r=Mark-Simulacrum
95597e8 
[beta] backports and stage0 bump

- bump stage0 to 1.87.0
- Update the edition guide for let chains #140852
- Fix download of GCC from CI on non-nightly channels #140901
- Revert "Fix linking statics on Arm64EC #140176" #141024
- [win][arm64] Remove 'Arm64 Hazard' undocumented MSVC option and instead disable problematic test #141045
- Do not call name() on rpitit assoc_item #141308
- Temporarily use Windows Server 2022 instead of Windows Server 2025 images #141023
- Use Docker cache from the current repository #141280
- Move dist-x86_64-linux CI job to GitHub temporarily #141388
- ci: prepare aws access keys for migration #141389
- Add bors environment to CI #141323
-  ci: split dist-arm-linux job #141078

r? cuviper
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@marcoieni marcoieni

Labels
A-testsuite Area: The testsuite used to check the correctness of rustc beta-accepted Accepted for backporting to the compiler in the beta channel. merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.88.0
Development

Successfully merging this pull request may close these issues.
7 participants
@Kobzol @marcoieni @bors @jieyouxu @rust-timer @cuviper @rustbot