Revert "Fix linking statics on Arm64EC #140176" #141024

jieyouxu · 2025-05-15T09:04:35Z

This reverts PR #140176.
Unfortunately, this will reopen #138541 (re-breaking the arm64ec-pc-windows-msvc target).

Unfortunately, multiple people are reporting linker warnings related to __rust_no_alloc_shim_is_unstable after this change in x86_64-pc-windows-msvc as well. The solution isn't quite clear yet, let's revert to avoid the linker warnings on the Tier 1 MSVC target for now¹, and try a reland with a determined solution for __rust_no_alloc_shim_is_unstable.

Judging from people reporting that they are observing this also when bootstrapping w/ stage0 rustc, we may have to cut a new beta and then repoint stage0 against that newer beta?

cc @dpaoliello @wesleywiser

r? @wesleywiser (or compiler)

Note that it's still RustWeek this week, so most team members are N/A. ↩

Unfortunately, multiple people are reporting linker warnings related to `__rust_no_alloc_shim_is_unstable` after this change. The solution isn't quite clear yet, let's revert to green for now, and try a reland with a determined solution for `__rust_no_alloc_shim_is_unstable`. This reverts commit c8b7f32, reversing changes made to 667247d.

rustbot · 2025-05-15T09:04:43Z

Some changes occurred in compiler/rustc_codegen_ssa

cc @WaffleLapkin

These commits modify compiler targets.
(See the Target Tier Policy.)

jieyouxu · 2025-05-15T09:06:29Z

Nominating this for beta backport because people are reporting seeing the linker warning in bootstrapping as well. However, the beta backport is a "pick your poison" situation, where we avoid the linker warnings in Tier 1 x86_64-pc-windows-msvc target but re-break Tier 2 arm64ec-pc-windows-msvc target.

@rustbot label: +beta-nominated

wesleywiser

r=me when CI is green

jieyouxu · 2025-05-15T10:11:01Z

CI is green.
@bors r=@wesleywiser rollup=never

bors · 2025-05-15T10:11:04Z

📌 Commit 734a5b1 has been approved by wesleywiser

It is now in the queue for this repository.

bors · 2025-05-15T10:11:04Z

🌲 The tree is currently closed for pull requests below priority 100. This pull request will be tested once the tree is reopened.

bors · 2025-05-17T07:00:49Z

⌛ Testing commit 734a5b1 with merge b0e9259...

bors · 2025-05-17T10:12:02Z

☀️ Test successful - checks-actions
Approved by: wesleywiser
Pushing b0e9259 to master...

github-actions · 2025-05-17T10:15:02Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing a69bc17 (parent) -> b0e9259 (this PR)

Test differences

Show 3 test diffs

Stage 1

[run-make] tests/run-make/arm64ec-import-export-static: ignore (only executed when the operating system is windows) -> [missing] (J2)

Stage 2

[run-make] tests/run-make/arm64ec-import-export-static: ignore (only executed when the operating system is windows) -> [missing] (J0)
[run-make] tests/run-make/arm64ec-import-export-static: pass -> [missing] (J1)

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard b0e925903a04fc3b2e0903ce6110938e871c61a1 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

x86_64-apple-2: 5192.9s -> 6222.2s (19.8%)
dist-apple-various: 7238.6s -> 6165.7s (-14.8%)
x86_64-rust-for-linux: 2561.4s -> 2824.7s (10.3%)
dist-x86_64-illumos: 5648.2s -> 6162.8s (9.1%)
mingw-check: 1216.0s -> 1314.9s (8.1%)
dist-x86_64-apple: 8418.5s -> 8995.4s (6.9%)
dist-i686-msvc: 7067.4s -> 6718.1s (-4.9%)
dist-various-1: 4403.6s -> 4620.9s (4.9%)
dist-arm-linux: 4578.8s -> 4797.6s (4.8%)
aarch64-gnu: 6647.8s -> 6337.5s (-4.7%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2025-05-17T11:44:10Z

Finished benchmarking commit (b0e9259): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary -1.6%, secondary -2.0%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	2.2%	[2.2%, 2.2%]	1
Regressions ❌ (secondary)	0.7%	[0.5%, 1.1%]	6
Improvements ✅ (primary)	-2.3%	[-4.2%, -0.8%]	6
Improvements ✅ (secondary)	-2.5%	[-3.7%, -1.0%]	36
All ❌✅ (primary)	-1.6%	[-4.2%, 2.2%]	7

Cycles

Results (secondary -0.0%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	1.3%	[0.6%, 2.1%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.6%	[-0.7%, -0.4%]	5
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 774.345s -> 775.66s (0.17%)
Artifact size: 365.45 MiB -> 365.38 MiB (-0.02%)

apiraino · 2025-05-22T14:10:45Z

Beta backport accepted as per compiler team on Zulip and here. A backport PR will be authored by the release team at the end of the current development cycle. Backport labels handled by them.

@rustbot label +beta-accepted

[beta] backports and stage0 bump - bump stage0 - Update the edition guide for let chains rust-lang#140852 - Fix download of GCC from CI on non-nightly channels rust-lang#140901 - Revert "Fix linking statics on Arm64EC rust-lang#140176" rust-lang#141024 - [win][arm64] Remove 'Arm64 Hazard' undocumented MSVC option and instead disable problematic test rust-lang#141045 - Do not call name() on rpitit assoc_item rust-lang#141308 r? cuviper

[beta] backports and stage0 bump - bump stage0 to 1.87.0 - Update the edition guide for let chains #140852 - Fix download of GCC from CI on non-nightly channels #140901 - Revert "Fix linking statics on Arm64EC #140176" #141024 - [win][arm64] Remove 'Arm64 Hazard' undocumented MSVC option and instead disable problematic test #141045 - Do not call name() on rpitit assoc_item #141308 - Temporarily use Windows Server 2022 instead of Windows Server 2025 images #141023 r? cuviper

[beta] backports and stage0 bump - bump stage0 to 1.87.0 - Update the edition guide for let chains #140852 - Fix download of GCC from CI on non-nightly channels #140901 - Revert "Fix linking statics on Arm64EC #140176" #141024 - [win][arm64] Remove 'Arm64 Hazard' undocumented MSVC option and instead disable problematic test #141045 - Do not call name() on rpitit assoc_item #141308 - Temporarily use Windows Server 2022 instead of Windows Server 2025 images #141023 - Use Docker cache from the current repository #141280 - Move dist-x86_64-linux CI job to GitHub temporarily #141388 - ci: prepare aws access keys for migration #141389 r? cuviper

[beta] backports and stage0 bump - bump stage0 to 1.87.0 - Update the edition guide for let chains #140852 - Fix download of GCC from CI on non-nightly channels #140901 - Revert "Fix linking statics on Arm64EC #140176" #141024 - [win][arm64] Remove 'Arm64 Hazard' undocumented MSVC option and instead disable problematic test #141045 - Do not call name() on rpitit assoc_item #141308 - Temporarily use Windows Server 2022 instead of Windows Server 2025 images #141023 - Use Docker cache from the current repository #141280 - Move dist-x86_64-linux CI job to GitHub temporarily #141388 - ci: prepare aws access keys for migration #141389 - Add bors environment to CI #141323 r? cuviper

[beta] backports and stage0 bump - bump stage0 to 1.87.0 - Update the edition guide for let chains #140852 - Fix download of GCC from CI on non-nightly channels #140901 - Revert "Fix linking statics on Arm64EC #140176" #141024 - [win][arm64] Remove 'Arm64 Hazard' undocumented MSVC option and instead disable problematic test #141045 - Do not call name() on rpitit assoc_item #141308 - Temporarily use Windows Server 2022 instead of Windows Server 2025 images #141023 - Use Docker cache from the current repository #141280 - Move dist-x86_64-linux CI job to GitHub temporarily #141388 - ci: prepare aws access keys for migration #141389 - Add bors environment to CI #141323 - ci: split dist-arm-linux job #141078 r? cuviper

To include beta backport of revert rust-lang#141024 which should undo linker warnings during bootstrapping of Windows MSVC targets due to rust-lang#140176.

To include beta backport of revert <rust-lang#141024> which should undo linker warnings during bootstrapping of Windows MSVC targets due to <rust-lang#140176>.

rustbot assigned wesleywiser May 15, 2025

rustbot added A-run-make Area: port run-make Makefiles to rmake.rs S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 15, 2025

jieyouxu mentioned this pull request May 15, 2025

Fix linking statics on Arm64EC #140176

Merged

rustbot added the beta-nominated Nominated for backporting to the compiler in the beta channel. label May 15, 2025

wesleywiser approved these changes May 15, 2025

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 15, 2025

bors added the merged-by-bors This PR was explicitly merged by bors. label May 17, 2025

bors merged commit b0e9259 into rust-lang:master May 17, 2025
7 checks passed

rustbot added this to the 1.89.0 milestone May 17, 2025

bors mentioned this pull request May 17, 2025

Reduce special casing for the panic runtime #140809

Open

jieyouxu deleted the revert-arm64ec branch May 17, 2025 12:34

dpaoliello mentioned this pull request May 19, 2025

Change __rust_no_alloc_shim_is_unstable to be a function #141061

Open

This was referenced May 22, 2025

Linking error when compiled to arm64ec-pc-windows-msvc #138541

Open

Bump stage0 after revert #141024 is backported to beta and a new beta is released #141395

Open

rustbot added the beta-accepted Accepted for backporting to the compiler in the beta channel. label May 22, 2025

cuviper mentioned this pull request May 22, 2025

[beta] backports and stage0 bump #141412

Merged

cuviper modified the milestones: 1.89.0, 1.88.0 May 22, 2025

cuviper removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label May 22, 2025

jieyouxu added a commit to jieyouxu/rust that referenced this pull request May 27, 2025

Bump master stage0 compiler

6846bf0

To include beta backport of revert rust-lang#141024 which should undo linker warnings during bootstrapping of Windows MSVC targets due to rust-lang#140176.

jieyouxu mentioned this pull request May 27, 2025

Bump master stage0 compiler #141647

Open

jieyouxu added a commit to jieyouxu/rust that referenced this pull request May 27, 2025

Bump master stage0 compiler

2490bba

To include beta backport of revert <rust-lang#141024> which should undo linker warnings during bootstrapping of Windows MSVC targets due to <rust-lang#140176>.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Revert "Fix linking statics on Arm64EC #140176" #141024

Revert "Fix linking statics on Arm64EC #140176" #141024

Uh oh!

jieyouxu commented May 15, 2025 •

edited

Loading

Uh oh!

rustbot commented May 15, 2025

Uh oh!

jieyouxu commented May 15, 2025 •

edited

Loading

Uh oh!

wesleywiser left a comment

Uh oh!

jieyouxu commented May 15, 2025

Uh oh!

bors commented May 15, 2025

Uh oh!

bors commented May 15, 2025

Uh oh!

bors commented May 17, 2025

Uh oh!

bors commented May 17, 2025

Uh oh!

Uh oh!

github-actions bot commented May 17, 2025

Stage 1

Stage 2

Uh oh!

rust-timer commented May 17, 2025

Uh oh!

apiraino commented May 22, 2025

Uh oh!

Uh oh!

Revert "Fix linking statics on Arm64EC #140176" #141024

Revert "Fix linking statics on Arm64EC #140176" #141024

Uh oh!

Conversation

jieyouxu commented May 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Footnotes

Uh oh!

rustbot commented May 15, 2025

Uh oh!

jieyouxu commented May 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wesleywiser left a comment

Choose a reason for hiding this comment

Uh oh!

jieyouxu commented May 15, 2025

Uh oh!

bors commented May 15, 2025

Uh oh!

bors commented May 15, 2025

Uh oh!

bors commented May 17, 2025

Uh oh!

bors commented May 17, 2025

Uh oh!

Uh oh!

github-actions bot commented May 17, 2025

Test differences

Stage 1

Stage 2

Job duration changes

Uh oh!

rust-timer commented May 17, 2025

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

apiraino commented May 22, 2025

Uh oh!

Uh oh!

jieyouxu commented May 15, 2025 •

edited

Loading

jieyouxu commented May 15, 2025 •

edited

Loading