Skip to content

Replace 'region' with 'lifetime' in a few transmute function names #13498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 16, 2014
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/doc/guide-unsafe.md
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ use std::cast;
let mut x: u8 = 1;

let ref_1: &mut u8 = &mut x;
let ref_2: &mut u8 = unsafe { cast::transmute_mut_region(ref_1) };
let ref_2: &mut u8 = unsafe { cast::transmute_mut_lifetime(ref_1) };

// oops, ref_1 and ref_2 point to the same piece of data (x) and are
// both usable
Expand Down
8 changes: 4 additions & 4 deletions src/libarena/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@

extern crate collections;

use std::cast::{transmute, transmute_mut, transmute_mut_region};
use std::cast::{transmute, transmute_mut, transmute_mut_lifetime};
use std::cast;
use std::cell::{Cell, RefCell};
use std::mem;
Expand Down Expand Up @@ -186,7 +186,7 @@ impl Arena {
#[inline]
fn alloc_copy_inner(&mut self, n_bytes: uint, align: uint) -> *u8 {
unsafe {
let this = transmute_mut_region(self);
let this = transmute_mut_lifetime(self);
let start = round_up(this.copy_head.fill.get(), align);
let end = start + n_bytes;
if end > self.chunk_size() {
Expand Down Expand Up @@ -233,7 +233,7 @@ impl Arena {
let after_tydesc;

{
let head = transmute_mut_region(&mut self.head);
let head = transmute_mut_lifetime(&mut self.head);

tydesc_start = head.fill.get();
after_tydesc = head.fill.get() + mem::size_of::<*TyDesc>();
Expand All @@ -245,7 +245,7 @@ impl Arena {
return self.alloc_noncopy_grow(n_bytes, align);
}

let head = transmute_mut_region(&mut self.head);
let head = transmute_mut_lifetime(&mut self.head);
head.fill.set(round_up(end, mem::pref_align_of::<*TyDesc>()));

//debug!("idx = {}, size = {}, align = {}, fill = {}",
Expand Down
6 changes: 3 additions & 3 deletions src/libgreen/sched.rs
Original file line number Diff line number Diff line change
Expand Up @@ -630,7 +630,7 @@ impl Scheduler {
unsafe {

let sched: &mut Scheduler =
cast::transmute_mut_region(*next_task.sched.get_mut_ref());
cast::transmute_mut_lifetime(*next_task.sched.get_mut_ref());

let current_task: &mut GreenTask = match sched.cleanup_job {
Some(CleanupJob { task: ref mut task, .. }) => &mut **task,
Expand Down Expand Up @@ -681,8 +681,8 @@ impl Scheduler {
let next_task_context =
&mut next_task.coroutine.get_mut_ref().saved_context;
unsafe {
(cast::transmute_mut_region(current_task_context),
cast::transmute_mut_region(next_task_context))
(cast::transmute_mut_lifetime(current_task_context),
cast::transmute_mut_lifetime(next_task_context))
}
}

Expand Down
14 changes: 7 additions & 7 deletions src/libstd/cast.rs
Original file line number Diff line number Diff line change
Expand Up @@ -63,9 +63,9 @@ pub unsafe fn transmute<L, G>(thing: L) -> G {
#[inline]
pub unsafe fn transmute_mut<'a,T>(ptr: &'a T) -> &'a mut T { transmute(ptr) }

/// Coerce a reference to have an arbitrary associated region.
/// Coerce a reference to have an arbitrary associated lifetime.
#[inline]
pub unsafe fn transmute_region<'a,'b,T>(ptr: &'a T) -> &'b T {
pub unsafe fn transmute_lifetime<'a,'b,T>(ptr: &'a T) -> &'b T {
transmute(ptr)
}

Expand All @@ -75,28 +75,28 @@ pub unsafe fn transmute_mut_unsafe<T>(ptr: *T) -> *mut T {
transmute(ptr)
}

/// Coerce a mutable reference to have an arbitrary associated region.
/// Coerce a mutable reference to have an arbitrary associated lifetime.
#[inline]
pub unsafe fn transmute_mut_region<'a,'b,T>(ptr: &'a mut T) -> &'b mut T {
pub unsafe fn transmute_mut_lifetime<'a,'b,T>(ptr: &'a mut T) -> &'b mut T {
transmute(ptr)
}

/// Transforms lifetime of the second pointer to match the first.
#[inline]
pub unsafe fn copy_lifetime<'a,S,T>(_ptr: &'a S, ptr: &T) -> &'a T {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these copy_* methods useful at all? It looks like they aren't used anywhere in this repo. Maybe we should just axe them.

transmute_region(ptr)
transmute_lifetime(ptr)
}

/// Transforms lifetime of the second pointer to match the first.
#[inline]
pub unsafe fn copy_mut_lifetime<'a,S,T>(_ptr: &'a mut S, ptr: &mut T) -> &'a mut T {
transmute_mut_region(ptr)
transmute_mut_lifetime(ptr)
}

/// Transforms lifetime of the second pointer to match the first.
#[inline]
pub unsafe fn copy_lifetime_vec<'a,S,T>(_ptr: &'a [S], ptr: &T) -> &'a T {
transmute_region(ptr)
transmute_lifetime(ptr)
}


Expand Down