Replace 'region' with 'lifetime' in a few transmute function names #13498
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| #[inline] | ||
| pub unsafe fn transmute_mut_region<'a,'b,T>(ptr: &'a mut T) -> &'b mut T { | ||
| pub unsafe fn transmute_mut_lifetime<'a,'b,T>(ptr: &'a mut T) -> &'b mut T { | ||
| transmute(ptr) | ||
| } | ||
|
|
||
| /// Transforms lifetime of the second pointer to match the first. | ||
| #[inline] | ||
| pub unsafe fn copy_lifetime<'a,S,T>(_ptr: &'a S, ptr: &T) -> &'a T { |
There was a problem hiding this comment.
Are these copy_* methods useful at all? It looks like they aren't used anywhere in this repo. Maybe we should just axe them.
bors
added a commit
that referenced
this pull request
Apr 16, 2014
…ichton Regions were renamed to lifetimes a while back, so these functions should probably be renamed as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regions were renamed to lifetimes a while back, so these functions should probably be renamed as well.