Skip to content

Tweak the interface of std::io #11598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 17, 2014
Merged

Conversation

alexcrichton
Copy link
Member

  • Reexport io::mem and io::buffered structs directly under io, make mem/buffered
    private modules
  • Remove with_mem_writer
  • Remove DEFAULT_CAPACITY and use DEFAULT_BUF_SIZE (in io::buffered)

cc #11119

@huonw
Copy link
Member

huonw commented Jan 16, 2014

make mem/buffered private modules

Does rustdoc handle this correctly? (I.e. will we still have MemWriter in the docs?)

@sfackler
Copy link
Member

@huonw it does now. A private item that's publicly reexported once has its docs inlined at the reexport site.

* Reexport io::mem and io::buffered structs directly under io, make mem/buffered
  private modules
* Remove with_mem_writer
* Remove DEFAULT_CAPACITY and use DEFAULT_BUF_SIZE (in io::buffered)
bors added a commit that referenced this pull request Jan 17, 2014
* Reexport io::mem and io::buffered structs directly under io, make mem/buffered
  private modules
* Remove with_mem_writer
* Remove DEFAULT_CAPACITY and use DEFAULT_BUF_SIZE (in io::buffered)

cc #11119
@bors bors closed this Jan 17, 2014
@bors bors merged commit 295b46f into rust-lang:master Jan 17, 2014
@alexcrichton alexcrichton deleted the io-export branch January 18, 2014 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants