Skip to content

Commit 9bf85a2

Browse files
committed
auto merge of #11598 : alexcrichton/rust/io-export, r=brson
* Reexport io::mem and io::buffered structs directly under io, make mem/buffered private modules * Remove with_mem_writer * Remove DEFAULT_CAPACITY and use DEFAULT_BUF_SIZE (in io::buffered) cc #11119
2 parents 4098327 + 295b46f commit 9bf85a2

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

41 files changed

+204
-180
lines changed

doc/complement-cheatsheet.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -62,8 +62,8 @@ let reader : File = File::open(&path).unwrap_or_else(on_error);
6262
Use the [`lines`](http://static.rust-lang.org/doc/master/std/io/trait.Buffer.html#method.lines) method on a [`BufferedReader`](http://static.rust-lang.org/doc/master/std/io/buffered/struct.BufferedReader.html).
6363

6464
~~~
65-
use std::io::buffered::BufferedReader;
66-
# use std::io::mem::MemReader;
65+
use std::io::BufferedReader;
66+
# use std::io::MemReader;
6767
6868
# let reader = MemReader::new(~[]);
6969

doc/guide-conditions.md

Lines changed: 20 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -46,12 +46,11 @@ An example program that does this task reads like this:
4646
~~~~
4747
# #[allow(unused_imports)];
4848
# extern mod extra;
49-
use std::io::buffered::BufferedReader;
50-
use std::io::File;
49+
use std::io::{BufferedReader, File};
5150
# mod BufferedReader {
5251
# use std::io::File;
53-
# use std::io::mem::MemReader;
54-
# use std::io::buffered::BufferedReader;
52+
# use std::io::MemReader;
53+
# use std::io::BufferedReader;
5554
# static s : &'static [u8] = bytes!("1 2\n\
5655
# 34 56\n\
5756
# 789 123\n\
@@ -245,13 +244,12 @@ and trapping its exit status using `task::try`:
245244
~~~~
246245
# #[allow(unused_imports)];
247246
# extern mod extra;
248-
use std::io::buffered::BufferedReader;
249-
use std::io::File;
247+
use std::io::{BufferedReader, File};
250248
use std::task;
251249
# mod BufferedReader {
252250
# use std::io::File;
253-
# use std::io::mem::MemReader;
254-
# use std::io::buffered::BufferedReader;
251+
# use std::io::MemReader;
252+
# use std::io::BufferedReader;
255253
# static s : &'static [u8] = bytes!("1 2\n\
256254
# 34 56\n\
257255
# 789 123\n\
@@ -350,12 +348,11 @@ but similarly clear as the version that used `fail!` in the logic where the erro
350348
~~~~
351349
# #[allow(unused_imports)];
352350
# extern mod extra;
353-
use std::io::buffered::BufferedReader;
354-
use std::io::File;
351+
use std::io::{BufferedReader, File};
355352
# mod BufferedReader {
356353
# use std::io::File;
357-
# use std::io::mem::MemReader;
358-
# use std::io::buffered::BufferedReader;
354+
# use std::io::MemReader;
355+
# use std::io::BufferedReader;
359356
# static s : &'static [u8] = bytes!("1 2\n\
360357
# 34 56\n\
361358
# 789 123\n\
@@ -420,12 +417,11 @@ and replaces bad input lines with the pair `(-1,-1)`:
420417
~~~~
421418
# #[allow(unused_imports)];
422419
# extern mod extra;
423-
use std::io::buffered::BufferedReader;
424-
use std::io::File;
420+
use std::io::{BufferedReader, File};
425421
# mod BufferedReader {
426422
# use std::io::File;
427-
# use std::io::mem::MemReader;
428-
# use std::io::buffered::BufferedReader;
423+
# use std::io::MemReader;
424+
# use std::io::BufferedReader;
429425
# static s : &'static [u8] = bytes!("1 2\n\
430426
# 34 56\n\
431427
# 789 123\n\
@@ -496,12 +492,11 @@ Changing the condition's return type from `(int,int)` to `Option<(int,int)>` wil
496492
~~~~
497493
# #[allow(unused_imports)];
498494
# extern mod extra;
499-
use std::io::buffered::BufferedReader;
500-
use std::io::File;
495+
use std::io::{BufferedReader, File};
501496
# mod BufferedReader {
502497
# use std::io::File;
503-
# use std::io::mem::MemReader;
504-
# use std::io::buffered::BufferedReader;
498+
# use std::io::MemReader;
499+
# use std::io::BufferedReader;
505500
# static s : &'static [u8] = bytes!("1 2\n\
506501
# 34 56\n\
507502
# 789 123\n\
@@ -582,12 +577,11 @@ This can be encoded in the handler API by introducing a helper type: `enum Malfo
582577
~~~~
583578
# #[allow(unused_imports)];
584579
# extern mod extra;
585-
use std::io::buffered::BufferedReader;
586580
use std::io::File;
587581
# mod BufferedReader {
588582
# use std::io::File;
589-
# use std::io::mem::MemReader;
590-
# use std::io::buffered::BufferedReader;
583+
# use std::io::MemReader;
584+
# use std::io::BufferedReader;
591585
# static s : &'static [u8] = bytes!("1 2\n\
592586
# 34 56\n\
593587
# 789 123\n\
@@ -707,12 +701,11 @@ a second condition and a helper function will suffice:
707701
~~~~
708702
# #[allow(unused_imports)];
709703
# extern mod extra;
710-
use std::io::buffered::BufferedReader;
711-
use std::io::File;
704+
use std::io::{BufferedReader, File};
712705
# mod BufferedReader {
713706
# use std::io::File;
714-
# use std::io::mem::MemReader;
715-
# use std::io::buffered::BufferedReader;
707+
# use std::io::MemReader;
708+
# use std::io::BufferedReader;
716709
# static s : &'static [u8] = bytes!("1 2\n\
717710
# 34 56\n\
718711
# 789 123\n\

src/compiletest/errors.rs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,7 @@
88
// option. This file may not be copied, modified, or distributed
99
// except according to those terms.
1010

11-
use std::io::buffered::BufferedReader;
12-
use std::io::File;
11+
use std::io::{BufferedReader, File};
1312

1413
pub struct ExpectedError { line: uint, kind: ~str, msg: ~str }
1514

src/compiletest/header.rs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -107,8 +107,7 @@ pub fn is_test_ignored(config: &config, testfile: &Path) -> bool {
107107
}
108108

109109
fn iter_header(testfile: &Path, it: |&str| -> bool) -> bool {
110-
use std::io::buffered::BufferedReader;
111-
use std::io::File;
110+
use std::io::{BufferedReader, File};
112111

113112
let mut rdr = BufferedReader::new(File::open(testfile).unwrap());
114113
for ln in rdr.lines() {

src/libextra/ebml.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -590,7 +590,7 @@ pub mod writer {
590590
use std::clone::Clone;
591591
use std::io;
592592
use std::io::{Writer, Seek};
593-
use std::io::mem::MemWriter;
593+
use std::io::MemWriter;
594594
use std::io::extensions::u64_to_be_bytes;
595595

596596
// ebml writing
@@ -943,7 +943,7 @@ mod tests {
943943
use serialize::Encodable;
944944
use serialize;
945945

946-
use std::io::mem::MemWriter;
946+
use std::io::MemWriter;
947947
use std::option::{None, Option, Some};
948948

949949
#[test]

src/libextra/json.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ use std::cast::transmute;
2121
use std::f64;
2222
use std::hashmap::HashMap;
2323
use std::io;
24-
use std::io::mem::MemWriter;
24+
use std::io::MemWriter;
2525
use std::num;
2626
use std::str;
2727
use std::to_str;
@@ -1506,7 +1506,7 @@ mod tests {
15061506
}
15071507
15081508
fn with_str_writer(f: |&mut io::Writer|) -> ~str {
1509-
use std::io::mem::MemWriter;
1509+
use std::io::MemWriter;
15101510
use std::str;
15111511
15121512
let mut m = MemWriter::new();

src/libextra/stats.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -998,7 +998,7 @@ mod tests {
998998
#[test]
999999
fn test_boxplot_nonpositive() {
10001000
fn t(s: &Summary, expected: ~str) {
1001-
use std::io::mem::MemWriter;
1001+
use std::io::MemWriter;
10021002
let mut m = MemWriter::new();
10031003
write_boxplot(&mut m as &mut io::Writer, s, 30);
10041004
let out = str::from_utf8_owned(m.unwrap());

src/libextra/test.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -673,7 +673,7 @@ pub fn run_tests_console(opts: &TestOpts,
673673

674674
#[test]
675675
fn should_sort_failures_before_printing_them() {
676-
use std::io::mem::MemWriter;
676+
use std::io::MemWriter;
677677
use std::str;
678678

679679
let test_a = TestDesc {

src/libextra/time.rs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,7 @@
1010

1111
#[allow(missing_doc)];
1212

13-
use std::io::Reader;
14-
use std::io::mem::BufReader;
13+
use std::io::BufReader;
1514
use std::libc;
1615
use std::num;
1716
use std::str;

src/libextra/url.rs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,7 @@
1212
1313
#[allow(missing_doc)];
1414

15-
use std::io::{Reader, Seek};
16-
use std::io::mem::BufReader;
15+
use std::io::BufReader;
1716
use std::cmp::Eq;
1817
use std::hashmap::HashMap;
1918
use std::to_bytes;

src/libextra/uuid.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -522,7 +522,7 @@ mod test {
522522
use std::str;
523523
use std::rand;
524524
use std::num::Zero;
525-
use std::io::mem::MemWriter;
525+
use std::io::MemWriter;
526526

527527
#[test]
528528
fn test_new_nil() {

src/libextra/workcache.rs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,7 @@ use arc::{Arc,RWArc};
1717
use treemap::TreeMap;
1818
use std::str;
1919
use std::io;
20-
use std::io::File;
21-
use std::io::mem::MemWriter;
20+
use std::io::{File, MemWriter};
2221

2322
/**
2423
*

src/librustc/driver/driver.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ use std::cell::{Cell, RefCell};
3131
use std::hashmap::{HashMap,HashSet};
3232
use std::io;
3333
use std::io::fs;
34-
use std::io::mem::MemReader;
34+
use std::io::MemReader;
3535
use std::os;
3636
use std::vec;
3737
use extra::getopts::groups::{optopt, optmulti, optflag, optflagopt};

src/librustc/metadata/encoder.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ use middle;
2424
use std::cast;
2525
use std::cell::{Cell, RefCell};
2626
use std::hashmap::{HashMap, HashSet};
27-
use std::io::mem::MemWriter;
27+
use std::io::MemWriter;
2828
use std::str;
2929
use std::vec;
3030

src/librustc/metadata/tyencode.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
use std::cell::RefCell;
1414
use std::hashmap::HashMap;
1515
use std::io;
16-
use std::io::mem::MemWriter;
16+
use std::io::MemWriter;
1717
use std::str;
1818
use std::fmt;
1919

src/librustc/middle/astencode.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1472,7 +1472,7 @@ fn mk_ctxt() -> @fake_ext_ctxt {
14721472

14731473
#[cfg(test)]
14741474
fn roundtrip(in_item: Option<@ast::Item>) {
1475-
use std::io::mem::MemWriter;
1475+
use std::io::MemWriter;
14761476

14771477
let in_item = in_item.unwrap();
14781478
let mut wr = MemWriter::new();

src/librustc/middle/liveness.rs

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -794,8 +794,9 @@ impl Liveness {
794794
}
795795

796796
pub fn ln_str(&self, ln: LiveNode) -> ~str {
797-
str::from_utf8_owned(io::mem::with_mem_writer(|wr| {
798-
let wr = wr as &mut io::Writer;
797+
let mut wr = io::MemWriter::new();
798+
{
799+
let wr = &mut wr as &mut io::Writer;
799800
{
800801
let lnks = self.ir.lnks.try_borrow();
801802
write!(wr,
@@ -823,7 +824,8 @@ impl Liveness {
823824
write!(wr, " precedes (successors borrowed)]");
824825
}
825826
}
826-
}))
827+
}
828+
str::from_utf8_owned(wr.unwrap())
827829
}
828830

829831
pub fn init_empty(&self, ln: LiveNode, succ_ln: LiveNode) {

src/librustdoc/html/render.rs

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -36,10 +36,8 @@
3636
use std::fmt;
3737
use std::hashmap::{HashMap, HashSet};
3838
use std::local_data;
39-
use std::io::buffered::BufferedWriter;
4039
use std::io;
41-
use std::io::fs;
42-
use std::io::File;
40+
use std::io::{fs, File, BufferedWriter};
4341
use std::str;
4442
use std::vec;
4543

src/librustdoc/lib.rs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,7 @@ extern mod extra;
2121

2222
use std::local_data;
2323
use std::io;
24-
use std::io::File;
25-
use std::io::mem::MemWriter;
24+
use std::io::{File, MemWriter};
2625
use std::str;
2726
use extra::getopts;
2827
use extra::getopts::groups;

src/libstd/fmt/mod.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -242,7 +242,7 @@ actually invoking the `write` function defined in this module. Example usage is:
242242
```rust
243243
use std::io;
244244
245-
let mut w = io::mem::MemWriter::new();
245+
let mut w = io::MemWriter::new();
246246
write!(&mut w as &mut io::Writer, "Hello {}!", "world");
247247
```
248248
@@ -470,7 +470,7 @@ use prelude::*;
470470

471471
use cast;
472472
use char::Char;
473-
use io::mem::MemWriter;
473+
use io::MemWriter;
474474
use io;
475475
use str;
476476
use repr;

0 commit comments

Comments
 (0)