update Miri #104617

RalfJung · 2022-11-19T23:16:10Z

r? @thomcc for the lib changes (removing a cfg(miri) that is no longer needed)

recreated by hand

- support pulling specific commit - make rust-version update a separate commit to avoid confusing josh - after pushing, check that we have a clear round-trip

empty commit to go through bors Go through bors once to clean up after the force push, have CI run, all the usual.

remove CI badge We don't actually run CI on the `master` branch (because bors checks things before they can even be on master), so this doesn't really show anything. rustc doesn't have a badge either. I think we can live without it. :D

implement clock_gettime on macos and pull in rustc changes so we can test this against rust-lang#103594. Fixes rust-lang/miri#2664

rustbot · 2022-11-19T23:16:17Z

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

Stabilizing library features
Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
Changing public documentation in ways that create new stability guarantees
Changing observable runtime behavior of library APIs

The Miri subtree was changed

cc @rust-lang/miri

thomcc · 2022-11-20T03:42:05Z

r=me on lib changes, which are trivial.

Rustup

RalfJung · 2022-11-20T08:16:21Z

@bors r+ p=1

bors · 2022-11-20T08:16:23Z

📌 Commit f70fd7853c9a0134997c37987c11b275ff9c16e0 has been approved by RalfJung

It is now in the queue for this repository.

make miri-seed a regular integer, and also set layout-seed in many-seeds This makes the seed format consistent between `-Zlayout-seed` and `-Zmiri-seed`.

RalfJung · 2022-11-20T09:57:11Z

@bors r-
I have an upcoming Miri PR that should be included

make align_offset always work on no-provenance pointers Fixes rust-lang/miri#2682

RalfJung · 2022-11-20T11:14:23Z

@bors r+ p=1

bors · 2022-11-20T11:14:24Z

📌 Commit c043a0e has been approved by RalfJung

It is now in the queue for this repository.

bors · 2022-11-20T12:57:52Z

⌛ Testing commit c043a0e with merge 911cbf8...

bors · 2022-11-20T16:04:16Z

☀️ Test successful - checks-actions
Approved by: RalfJung
Pushing 911cbf8 to master...

rust-timer · 2022-11-20T17:23:49Z

Finished benchmarking commit (911cbf8): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.7%	[-0.9%, -0.5%]	7
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.7%	[-0.9%, -0.5%]	7

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.2%	[2.2%, 2.2%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Cycles

This benchmark run did not return any relevant results for this metric.

lqd · 2022-11-21T08:54:21Z

Note for weekly triage: bitmaps is currently noisy

update Miri r? `@thomcc` for the lib changes (removing a `cfg(miri)` that is no longer needed)

RalfJung and others added 14 commits November 17, 2022 11:58

clean up retagging recursive traversal a bit

f1a8701

Auto merge of rust-lang#2670 - RalfJung:retag, r=RalfJung

331b93a

recreated by hand

remove unused shell_escape dep

d0a7ae1

Auto merge of rust-lang#2671 - klensy:shell_escape, r=RalfJung

3de7c28

recreated by hand

update josh scripts

da4eb35

- support pulling specific commit - make rust-version update a separate commit to avoid confusing josh - after pushing, check that we have a clear round-trip

update rust-version

9554395

empty commit to go through bors

a00a094

Auto merge of rust-lang#2676 - RalfJung:empty, r=RalfJung

db0a48c

empty commit to go through bors Go through bors once to clean up after the force push, have CI run, all the usual.

remove CI badge

8ec2149

Preparing for merge from rustc

e2f6a1b

Merge from rustc

81ee8c1

implement clock_gettime on macos

21321f5

Auto merge of rust-lang#2679 - RalfJung:clock_gettime, r=RalfJung

fc105ef

implement clock_gettime on macos and pull in rustc changes so we can test this against rust-lang#103594. Fixes rust-lang/miri#2664

rustbot assigned thomcc Nov 19, 2022

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Nov 19, 2022

This comment has been minimized.

Sign in to view

RalfJung and others added 4 commits November 20, 2022 07:48

Preparing for merge from rustc

aada2d1

Merge from rustc

3865e65

fix unused warning in a test

4da7d4b

Auto merge of rust-lang#2680 - RalfJung:rustup, r=RalfJung

0a9e5e8

Rustup

RalfJung force-pushed the miri branch from 975f74d to f70fd78 Compare November 20, 2022 08:15

rustbot added the T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) label Nov 20, 2022

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 20, 2022

RalfJung and others added 2 commits November 20, 2022 10:49

make miri-seed a regular integer, and also set layout-seed in many-seeds

772d521

Auto merge of rust-lang#2681 - RalfJung:seed, r=oli-obk

c26b510

make miri-seed a regular integer, and also set layout-seed in many-seeds This makes the seed format consistent between `-Zlayout-seed` and `-Zmiri-seed`.

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 20, 2022

RalfJung and others added 4 commits November 20, 2022 11:01

make align_offset always work on no-provenance pointers

c8c82a0

Auto merge of rust-lang#2683 - RalfJung:align_offset, r=RalfJung

8459a16

make align_offset always work on no-provenance pointers Fixes rust-lang/miri#2682

update lockfile

a689eb0

cfg(miri) no longer needed in sys/unix/time.rs

c043a0e

RalfJung force-pushed the miri branch from f70fd78 to c043a0e Compare November 20, 2022 11:13

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 20, 2022

bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 20, 2022

bors merged commit 911cbf8 into rust-lang:master Nov 20, 2022

rustbot added this to the 1.67.0 milestone Nov 20, 2022

RalfJung deleted the miri branch November 21, 2022 21:27

RalfJung mentioned this pull request Nov 27, 2022

Rustup rust-lang/miri#2702

Merged

Aaron1011 pushed a commit to Aaron1011/rust that referenced this pull request Jan 6, 2023

Auto merge of rust-lang#104617 - RalfJung:miri, r=RalfJung

95289c3

update Miri r? `@thomcc` for the lib changes (removing a `cfg(miri)` that is no longer needed)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

update Miri #104617

update Miri #104617

Uh oh!

RalfJung commented Nov 19, 2022

Uh oh!

rustbot commented Nov 19, 2022

Uh oh!

This comment has been minimized.

thomcc commented Nov 20, 2022

Uh oh!

RalfJung commented Nov 20, 2022

Uh oh!

bors commented Nov 20, 2022

Uh oh!

RalfJung commented Nov 20, 2022

Uh oh!

RalfJung commented Nov 20, 2022

Uh oh!

bors commented Nov 20, 2022

Uh oh!

bors commented Nov 20, 2022

Uh oh!

bors commented Nov 20, 2022

Uh oh!

rust-timer commented Nov 20, 2022

Uh oh!

lqd commented Nov 21, 2022

Uh oh!

Uh oh!

update Miri #104617

update Miri #104617

Uh oh!

Conversation

RalfJung commented Nov 19, 2022

Uh oh!

rustbot commented Nov 19, 2022

Uh oh!

This comment has been minimized.

thomcc commented Nov 20, 2022

Uh oh!

RalfJung commented Nov 20, 2022

Uh oh!

bors commented Nov 20, 2022

Uh oh!

RalfJung commented Nov 20, 2022

Uh oh!

RalfJung commented Nov 20, 2022

Uh oh!

bors commented Nov 20, 2022

Uh oh!

bors commented Nov 20, 2022

Uh oh!

bors commented Nov 20, 2022

Uh oh!

rust-timer commented Nov 20, 2022

Overall result: ✅ improvements - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Uh oh!

lqd commented Nov 21, 2022

Uh oh!

Uh oh!