Fix linking statics on Arm64EC #140176

dpaoliello · 2025-04-22T22:21:37Z

Arm64EC builds recently started to fail due to the linker not finding a symbol:

symbols.o : error LNK2001: unresolved external symbol #_ZN3std9panicking11EMPTY_PANIC17hc8d2b903527827f1E (EC Symbol)
          C:\Code\hello-world\target\arm64ec-pc-windows-msvc\debug\deps\hello_world.exe : fatal error LNK1120: 1 unresolved externals

It turns out that EMPTY_PANIC is a new static variable that was being exported then imported from the standard library, but when exporting LLVM didn't prepend the name with # (as only functions are prefixed with this character), whereas Rust was prefixing with # when attempting to import it.

The fix is to have Rust not prefix statics with # when importing.

Adding tests discovered another issue: we need to correctly mark static exported from dylibs with DATA, otherwise MSVC's linker assumes they are functions and complains that there is no exit thunk for them.

CI found another bug: we only apply DllImport to non-local statics that aren't foreign items (i.e., in an extern block), that is we want to use DllImport for statics coming from other Rust crates. However, __rust_no_alloc_shim_is_unstable is a static generated by the Rust compiler if required, but downstream crates consider it a foreign item since it is declared in an extern "Rust" block, thus they do not apply DllImport to it and so fails to link if it is exported by the previous crate as DATA. The fix is to apply DllImport to foreign items that are marked with the rustc_std_internal_symbol attribute (i.e., we assume they aren't actually foreign and will be in some Rust crate).

Fixes #138541

try-job: dist-aarch64-msvc
try-job: dist-x86_64-msvc
try-job: x86_64-msvc-1
try-job: x86_64-msvc-2

rustbot · 2025-04-22T22:21:41Z

r? @Nadrieril

rustbot has assigned @Nadrieril.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot · 2025-04-22T22:21:43Z

Some changes occurred in compiler/rustc_codegen_ssa

cc @WaffleLapkin

wesleywiser

Changes look good to me. Is it possible to write a regression test? (Either a full-scale integration test that links an exported static from one crate to another or a test that imports a static and dumps the symbol name or something?)

Nadrieril · 2025-04-23T23:21:45Z

r? @wesleywiser

wesleywiser · 2025-04-25T13:19:53Z

@rustbot author

rustbot · 2025-04-25T13:19:57Z

Reminder, once the PR becomes ready for a review, use @rustbot ready.

rustbot · 2025-04-25T23:45:31Z

This PR modifies run-make tests.

cc @jieyouxu

dpaoliello · 2025-04-25T23:46:25Z

Changes look good to me. Is it possible to write a regression test? (Either a full-scale integration test that links an exported static from one crate to another or a test that imports a static and dumps the symbol name or something?)

Good call, found another bug: we need to correctly export variables as DATA otherwise the linker expects them to have thunks.

@rustbot ready

tests/run-make/crate-import-export-static/rmake.rs

wesleywiser · 2025-04-29T20:02:41Z

Thanks @dpaoliello!

@bors r+ rollup

Also nominating for potential beta backport as this fixes a serious issue for the Tier 2 aarch64-pc-windows-msvc.

bors · 2025-04-29T20:02:44Z

📌 Commit 7370c5c has been approved by wesleywiser

It is now in the queue for this repository.

zmodem · 2025-05-12T12:53:16Z

We're hitting lld errors when building cargo after this change:

locally defined symbol imported: __rust_no_alloc_shim_is_unstable [...] LNK4217

It sounds like something is applying dllimport to __rust_no_alloc_shim_is_unstable even though it's part of the same image.

Actually, I see you're hitting the same thing in this test: https://github.com/rust-lang/rust/pull/140176/files#diff-f31e13197ab771a198513dbb749c33ae9195b4814c5a358deca1294a112adbc1

Is this intentional? And if so, do the build files need to be updated to ignore the warning?

(Our reference: https://crbug.com/417168093)

dpaoliello · 2025-05-12T16:28:33Z

We're hitting lld errors when building cargo after this change:
locally defined symbol imported: __rust_no_alloc_shim_is_unstable [...] LNK4217
It sounds like something is applying dllimport to __rust_no_alloc_shim_is_unstable even though it's part of the same image.

Actually, I see you're hitting the same thing in this test: https://github.com/rust-lang/rust/pull/140176/files#diff-f31e13197ab771a198513dbb749c33ae9195b4814c5a358deca1294a112adbc1

Is this intentional? And if so, do the build files need to be updated to ignore the warning?

(Our reference: https://crbug.com/417168093)

Yes, this warning is expected: __rust_no_alloc_shim_is_unstable is marked as extern "Rust" in the standard library, but the compiler generates a definition for it.

The correct fix would be for compiler/rustc_codegen_llvm/src/consts.rs to know if the current crate is generating the definition or not (thus whether dllimport is correct or not).

It's interesting that MSVC's linker reported this as warning 4286 whereas lld is reporting it as 4217.

I'll submit a change to ignore 4217 as well.

zmodem · 2025-05-14T10:45:21Z

Hmm, while that fixes our build of cargo, we're now hitting the same warning when linking Chromium, and we definitely don't want to disable this warning globally.

This seems like a regression.

dpaoliello · 2025-05-14T17:02:17Z

@bjorn3 is this something you can help with?

There are two ways that this could be fixed without needing a warning suppression for the linker:

Either consts.rs needs to be made aware of when the compiler is planning to emit the definition for __rust_no_alloc_shim_is_unstable and so it should not be marked as dllimport
If the compiler is planning to emit the definition of __rust_no_alloc_shim_is_unstable it modifies the corresponding def to mark the static as being local (this needs to be done early enough that const.rs hasn't been called yet).

I don't know enough about the architecture of the compiler to know which of these approaches is plausible, though I would argue that the second is more "correct" (i.e., we are no longer lying to the compiler and telling it that __rust_no_alloc_shim_is_unstable is non-local and foreign, then emitting a definition for it).

nico · 2025-05-14T23:40:46Z

If it takes a while to figure out a good way forward, would it be possible to revert to green in the meantime?

erickt · 2025-05-15T00:09:35Z

We're also running into this issue on Fuchsia trying to build our stage0 windows rustc. If we do a revert, could we also cut a new stage0 as well?

jieyouxu · 2025-05-15T08:41:31Z

The beta backport nomination was rejected in the compiler async backport thread.

@rustbot label: -beta-nominated

jieyouxu · 2025-05-15T08:42:54Z

The timing here is a bit unfortunate because most team members are N/A this week due to RustWeek / All Hands. I think it's safer to attempt a revert at this time, before we figure out a better solution for __rust_no_alloc_shim_is_unstable.

EDIT: revert PR is #141024.

Unfortunately, multiple people are reporting linker warnings related to `__rust_no_alloc_shim_is_unstable` after this change. The solution isn't quite clear yet, let's revert to green for now, and try a reland with a determined solution for `__rust_no_alloc_shim_is_unstable`. This reverts commit c8b7f32, reversing changes made to 667247d.

Revert "Fix linking statics on Arm64EC rust-lang#140176" This reverts PR rust-lang#140176. Unfortunately, this will reopen rust-lang#138541 (re-breaking the `arm64ec-pc-windows-msvc` target). Unfortunately, multiple people are [reporting linker warnings related to `__rust_no_alloc_shim_is_unstable`](rust-lang#140176 (comment)) after this change in `x86_64-pc-windows-msvc` as well. The solution isn't quite clear yet, let's revert to avoid the linker warnings on the Tier 1 MSVC target for now[^timing], and try a reland with a determined solution for `__rust_no_alloc_shim_is_unstable`. Judging from [people reporting that they are observing this also when bootstrapping w/ stage0 rustc](rust-lang#140176 (comment)), we may have to cut a new beta and then repoint stage0 against that newer beta? cc `@dpaoliello` `@wesleywiser` r? `@wesleywiser` (or compiler) [^timing]: Note that it's still RustWeek this week, so most team members are N/A.

Revert "Fix linking statics on Arm64EC #140176" This reverts PR #140176. Unfortunately, this will reopen rust-lang/rust#138541 (re-breaking the `arm64ec-pc-windows-msvc` target). Unfortunately, multiple people are [reporting linker warnings related to `__rust_no_alloc_shim_is_unstable`](rust-lang/rust#140176 (comment)) after this change in `x86_64-pc-windows-msvc` as well. The solution isn't quite clear yet, let's revert to avoid the linker warnings on the Tier 1 MSVC target for now[^timing], and try a reland with a determined solution for `__rust_no_alloc_shim_is_unstable`. Judging from [people reporting that they are observing this also when bootstrapping w/ stage0 rustc](rust-lang/rust#140176 (comment)), we may have to cut a new beta and then repoint stage0 against that newer beta? cc `@dpaoliello` `@wesleywiser` r? `@wesleywiser` (or compiler) [^timing]: Note that it's still RustWeek this week, so most team members are N/A.

Unfortunately, multiple people are reporting linker warnings related to `__rust_no_alloc_shim_is_unstable` after this change. The solution isn't quite clear yet, let's revert to green for now, and try a reland with a determined solution for `__rust_no_alloc_shim_is_unstable`. This reverts commit c8b7f32, reversing changes made to 667247d. (cherry picked from commit 734a5b1)

[beta] backports and stage0 bump - bump stage0 - Update the edition guide for let chains rust-lang#140852 - Fix download of GCC from CI on non-nightly channels rust-lang#140901 - Revert "Fix linking statics on Arm64EC rust-lang#140176" rust-lang#141024 - [win][arm64] Remove 'Arm64 Hazard' undocumented MSVC option and instead disable problematic test rust-lang#141045 - Do not call name() on rpitit assoc_item rust-lang#141308 r? cuviper

[beta] backports and stage0 bump - bump stage0 to 1.87.0 - Update the edition guide for let chains #140852 - Fix download of GCC from CI on non-nightly channels #140901 - Revert "Fix linking statics on Arm64EC #140176" #141024 - [win][arm64] Remove 'Arm64 Hazard' undocumented MSVC option and instead disable problematic test #141045 - Do not call name() on rpitit assoc_item #141308 - Temporarily use Windows Server 2022 instead of Windows Server 2025 images #141023 r? cuviper

[beta] backports and stage0 bump - bump stage0 to 1.87.0 - Update the edition guide for let chains #140852 - Fix download of GCC from CI on non-nightly channels #140901 - Revert "Fix linking statics on Arm64EC #140176" #141024 - [win][arm64] Remove 'Arm64 Hazard' undocumented MSVC option and instead disable problematic test #141045 - Do not call name() on rpitit assoc_item #141308 - Temporarily use Windows Server 2022 instead of Windows Server 2025 images #141023 - Use Docker cache from the current repository #141280 - Move dist-x86_64-linux CI job to GitHub temporarily #141388 - ci: prepare aws access keys for migration #141389 r? cuviper

[beta] backports and stage0 bump - bump stage0 to 1.87.0 - Update the edition guide for let chains #140852 - Fix download of GCC from CI on non-nightly channels #140901 - Revert "Fix linking statics on Arm64EC #140176" #141024 - [win][arm64] Remove 'Arm64 Hazard' undocumented MSVC option and instead disable problematic test #141045 - Do not call name() on rpitit assoc_item #141308 - Temporarily use Windows Server 2022 instead of Windows Server 2025 images #141023 - Use Docker cache from the current repository #141280 - Move dist-x86_64-linux CI job to GitHub temporarily #141388 - ci: prepare aws access keys for migration #141389 - Add bors environment to CI #141323 r? cuviper

[beta] backports and stage0 bump - bump stage0 to 1.87.0 - Update the edition guide for let chains #140852 - Fix download of GCC from CI on non-nightly channels #140901 - Revert "Fix linking statics on Arm64EC #140176" #141024 - [win][arm64] Remove 'Arm64 Hazard' undocumented MSVC option and instead disable problematic test #141045 - Do not call name() on rpitit assoc_item #141308 - Temporarily use Windows Server 2022 instead of Windows Server 2025 images #141023 - Use Docker cache from the current repository #141280 - Move dist-x86_64-linux CI job to GitHub temporarily #141388 - ci: prepare aws access keys for migration #141389 - Add bors environment to CI #141323 - ci: split dist-arm-linux job #141078 r? cuviper

To include beta backport of revert rust-lang#141024 which should undo linker warnings during bootstrapping of Windows MSVC targets due to rust-lang#140176.

To include beta backport of revert <rust-lang#141024> which should undo linker warnings during bootstrapping of Windows MSVC targets due to <rust-lang#140176>.

…troalbini Bump master `stage0` compiler To include beta backport of revert rust-lang#141024 which should undo linker warnings during bootstrapping of Windows MSVC targets due to rust-lang#140176. Closes rust-lang#141395. r? `@Mark-Simulacrum` (or release)

Rollup merge of #141647 - jieyouxu:bump-master-stage0, r=pietroalbini Bump master `stage0` compiler To include beta backport of revert #141024 which should undo linker warnings during bootstrapping of Windows MSVC targets due to #140176. Closes #141395. r? `@Mark-Simulacrum` (or release)

Bump master `stage0` compiler To include beta backport of revert rust-lang/rust#141024 which should undo linker warnings during bootstrapping of Windows MSVC targets due to rust-lang/rust#140176. Closes rust-lang/rust#141395. r? `@Mark-Simulacrum` (or release)

rustbot assigned Nadrieril Apr 22, 2025

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 22, 2025

dpaoliello changed the title ~~[Arm64EC] Only decorate functions with #~~ [Arm64EC] Only decorate functions, not statics, with # Apr 22, 2025

wesleywiser approved these changes Apr 23, 2025

View reviewed changes

rustbot assigned wesleywiser and unassigned Nadrieril Apr 23, 2025

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 25, 2025

dpaoliello force-pushed the arm64ecdec branch from 7b715cf to 60f35c8 Compare April 25, 2025 23:45

rustbot added the A-run-make Area: port run-make Makefiles to rmake.rs label Apr 25, 2025

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 25, 2025

dpaoliello changed the title ~~[Arm64EC] Only decorate functions, not statics, with #~~ Fix linking statics on Arm64EC Apr 25, 2025

wesleywiser reviewed Apr 29, 2025

View reviewed changes

tests/run-make/crate-import-export-static/rmake.rs Outdated Show resolved Hide resolved

dpaoliello force-pushed the arm64ecdec branch from 60f35c8 to b714161 Compare April 29, 2025 17:24

This comment has been minimized.

Sign in to view

dpaoliello force-pushed the arm64ecdec branch from b714161 to 7370c5c Compare April 29, 2025 18:12

wesleywiser approved these changes Apr 29, 2025

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 29, 2025

This was referenced May 12, 2025

[win] Ignore MSVC linker warning 4217 #140954

Closed

[win] Use a dash instead of slash for linker to avoid breaking lld #140977

Closed

rustbot removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label May 15, 2025

jieyouxu mentioned this pull request May 15, 2025

Revert "Fix linking statics on Arm64EC #140176" #141024

Merged

dpaoliello mentioned this pull request May 19, 2025

Change __rust_no_alloc_shim_is_unstable to be a function #141061

Open

jieyouxu mentioned this pull request May 22, 2025

Bump stage0 after revert #141024 is backported to beta and a new beta is released #141395

Closed

cuviper mentioned this pull request May 22, 2025

[beta] backports and stage0 bump #141412

Merged

jieyouxu added a commit to jieyouxu/rust that referenced this pull request May 27, 2025

Bump master stage0 compiler

6846bf0

To include beta backport of revert rust-lang#141024 which should undo linker warnings during bootstrapping of Windows MSVC targets due to rust-lang#140176.

jieyouxu mentioned this pull request May 27, 2025

Bump master stage0 compiler #141647

Merged

jieyouxu added a commit to jieyouxu/rust that referenced this pull request May 27, 2025

Bump master stage0 compiler

2490bba

To include beta backport of revert <rust-lang#141024> which should undo linker warnings during bootstrapping of Windows MSVC targets due to <rust-lang#140176>.

Fix linking statics on Arm64EC #140176

Fix linking statics on Arm64EC #140176

Uh oh!

Conversation

dpaoliello commented Apr 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Apr 22, 2025

Uh oh!

rustbot commented Apr 22, 2025

Uh oh!

wesleywiser left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Nadrieril commented Apr 23, 2025

Uh oh!

wesleywiser commented Apr 25, 2025

Uh oh!

rustbot commented Apr 25, 2025

Uh oh!

rustbot commented Apr 25, 2025

Uh oh!

dpaoliello commented Apr 25, 2025

Uh oh!

Uh oh!

This comment has been minimized.

wesleywiser commented Apr 29, 2025

Uh oh!

bors commented Apr 29, 2025

Uh oh!

zmodem commented May 12, 2025

Uh oh!

dpaoliello commented May 12, 2025

Uh oh!

zmodem commented May 14, 2025

Uh oh!

dpaoliello commented May 14, 2025

Uh oh!

nico commented May 14, 2025

Uh oh!

erickt commented May 15, 2025

Uh oh!

jieyouxu commented May 15, 2025

Uh oh!

jieyouxu commented May 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

dpaoliello commented Apr 22, 2025 •

edited

Loading

wesleywiser left a comment •

edited

Loading

jieyouxu commented May 15, 2025 •

edited

Loading