Fix indent level for build.rs example #1431
Conversation
jyn514
added
A-frontend
templates/core/Cargo.toml.example
Outdated
| @@ -1,4 +1,4 @@ | |||
| {# The example Cargo.toml used in about.html #} | |||
| {~# The example Cargo.toml used in about.html #~} | |||
There was a problem hiding this comment.
Is this not being rendered by tera, not handlebars? AFAICT from the docs tera has no way to control whitespace in comments (though, if it did, it'd be {#- The example ... -#}).
There was a problem hiding this comment.
Yeah, this will be rendered inline, and -#} doesn't work to suppress the post-comment-whitespace:
"{# foobar #}\n"
=> Ok("\n")
"{# foobar -#}\n"
=> Ok("\n")
"{~# foobar #~}\n"
=> Ok("{~# foobar #~}\n")
"{% if true %}{% endif -%}\n"
=> Ok("")
There was a problem hiding this comment.
When I check the /about/metadata, this actually makes the comment visible in the page, which I assume is not what we want.
There was a problem hiding this comment.
we could fix this here to reduce the space on the top of the code-section on that page, or revert this change
There was a problem hiding this comment.
Ok, fixed it by putting [package] on the same line as the comment.
templates/core/Cargo.toml.example
Outdated
| @@ -1,4 +1,4 @@ | |||
| {# The example Cargo.toml used in about.html #} | |||
| {~# The example Cargo.toml used in about.html #~} | |||
There was a problem hiding this comment.
When I check the /about/metadata, this actually makes the comment visible in the page, which I assume is not what we want.
templates/core/Cargo.toml.example
Outdated
| @@ -1,4 +1,4 @@ | |||
| {# The example Cargo.toml used in about.html #} | |||
| {~# The example Cargo.toml used in about.html #~} | |||
There was a problem hiding this comment.
we could fix this here to reduce the space on the top of the code-section on that page, or revert this change
syphar
added
S-waiting-on-author
This is a followup to rust-lang#1315 to fix the extra blank line at the top and to fix the indentation.
jyn514
added
S-waiting-on-review
Follow-up to #1325.
r? @syphar