-
Notifications
You must be signed in to change notification settings - Fork 210
Better fix code blocks in /about
#1325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This is a followup to rust-lang#1315 to fix the extra blank line at the top and to fix the indentation.
/about/
/about
{% filter dedent(levels=4) -%} | ||
<pre><code class="lang-rust"> | ||
if let Ok(_) = std::env::var("DOCS_RS") { | ||
{% filter dedent(levels=3) -%} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hopefully the removal of the newline after <pre><code>
will interact nicely with this dedent level...
Can you post a screenshot of what this looks like? |
Unfortunately I can't because I don't have a local docs.rs dev environment. |
You should be able to build the web server even if crate builds don't work. Try |
I'm getting errors like |
Please read the README. You need to copy the .env.sample file to .env. |
I assumed that section of the README was irrelevant because it described using docker-compose and downloading a bunch of crate data. |
If you're not building crates, all parts of the readme are still relevant except the ones explicitly about building crates:
Everything else is still accurate. If you like you could make a PR clarifying it :) |
@camelid are you still interested in working on this? |
Yeah, sorry for the delay! I just haven't gotten around to setting up the dev environment.
Thank you for testing it! I'm glad it works :)
I just pushed up a commit that should fix that (eea9807). Could you check if it works? Thanks :) |
I'd prefer to help you get the development environment working - let me know if you run into trouble with that. |
@camelid are you still planning to work on this? |
Closing due to inactivity. |
This is a followup to #1315 to fix the extra blank line at the top and
to fix the indentation.
This fix is based on this suggestion: #1315 (comment)