Fix IP-based request blocking for large page numbers #7434
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... instead of the `X-Real-Ip` header
LawnGnome
approved these changes
Nov 2, 2023
| if config | ||
| .page_offset_cidr_blocklist | ||
| .iter() | ||
| .any(|blocked| blocked.contains(client_ip)) | ||
| .any(|blocked| blocked.contains(**client_ip)) |
There was a problem hiding this comment.
And here I thought I'd left asterisk combinations back in my C days.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#7364 was a bit too eager to remove the
X-Real-Ipheader from nginx. As it turns out the header was/is still used in two places in our codebase, but the lowercase header value did not show up in my code search back then… 🙈Anyway, this PR fixes the IP-based request blocking use-case for large page numbers by using the
RealIprequest extension that was introduced in #7432.