Remove X-Real-Ip header
#7364
Merged
Remove X-Real-Ip header
#7364
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has been replaced by our own custom `X-Forwarded-For` logging
Turbo87
added
C-internal 🔧
|
#7359 has been running in production for a day now without any issues or differences to the nginx algorithm. let's get this merged to reduce our log volume again :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is essentially a continuation of #7302, which was unlocked by #7359. Since we process the
X-Forwarded-Forheader now in the same way that nginx does (plus the Heroku workaround...), we no longer need to have nginx do the same thing. This removes one more reason for us to still use nginx on our servers.