GitHub Secret Scanning improvements #5638
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The comparison is essentially the same, but slightly more straight forward to understand.
…` function We shouldn't panic if the network call fails, instead we can forward the error and return a 500 response.
Turbo87
added
C-internal 🔧
… function The logic is essentially the same, but using `find()` and `let-else` to simplify the code.
…N parsing We can use `from_slice()` instead to simplify the code
If GitHub reports a potential token we should treat false positives as legitimate cases instead of errors. Only real errors like failing to revoke a token should be considered errors.
Turbo87
force-pushed
the
gh-secret-alerts
branch
from
4067970 to
27c3e79
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds on top of #5495 and improves the code a little bit more. See the individual commit messages for more details.