Add API endpoint to receive alerts of exposed API tokens from GitHub #5495
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turbo87
force-pushed
the
gh-secret-alerts
branch
2 times, most recently
from
ef20a89 to
2c285a7
Compare
Turbo87
reviewed
Nov 20, 2022
Turbo87
added
C-enhancement ✨
|
Thanks for the feedback, I'll be working on that. |
|
☔ The latest upstream changes (presumably #5535) made this pull request unmergeable. Please resolve the merge conflicts. |
dangardner
force-pushed
the
gh-secret-alerts
branch
from
2c285a7 to
43f7796
Compare
Turbo87
force-pushed
the
gh-secret-alerts
branch
from
c2ed6b3 to
da0d846
Compare
|
rebased once more due to |
Turbo87
force-pushed
the
gh-secret-alerts
branch
from
da0d846 to
b742928
Compare
Turbo87
approved these changes
Dec 13, 2022
|
👋 I'm on the Secret Scanning team too. Just tested out the endpoint with some real API tokens, and things look good from our side! I received the email from crates.io as well! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new POST endpoint at
/tokens/alert/githubto receive alerts from GitHub when crates.io API tokens are exposed.Requires adding a dependency on ring for ECDSA signature validation.
Intended to resolve #3400.