Skip to content

feat: update mirage tests and route handlers for owner invites #5397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

feat: update mirage tests and route handlers for owner invites #5397

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6af5959
feat: update mirage tests and route handlers for owner invites
LeoBorai Oct 31, 2022
7ecadfd
fix: keep both endpoints
LeoBorai Oct 31, 2022
974476a
fix: remove expires at
LeoBorai Nov 3, 2022
b3034ac
fix: reintroduce module for tests
LeoBorai Nov 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions mirage/route-handlers/me.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,15 @@ export function register(server) {
return schema.crateOwnerInvitations.where({ inviteeId: user.id });
});

server.get('/api/private/crate_owner_invitations', function (schema) {
let { user } = getSession(schema);
if (!user) {
return new Response(403, {}, { errors: [{ detail: 'must be logged in to perform that action' }] });
}

return schema.crateOwnerInvitations.where({ inviteeId: user.id });
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the new endpoint actually works a little bit different. it supports (and iirc requires) query parameters to determine which invites to show.

});

server.put('/api/v1/me/crate_owner_invitations/:crate_id', (schema, request) => {
let { user } = getSession(schema);
if (!user) {
Expand Down
99 changes: 97 additions & 2 deletions tests/mirage/me/crate-owner-invitations/list-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ module('Mirage | GET /api/v1/me/crate_owner_invitations', function (hooks) {
inviter: inviter2,
});

let response = await fetch('/api/v1/me/crate_owner_invitations');
let response = await fetch('/api/private/crate_owner_invitations');
assert.equal(response.status, 200);
assert.deepEqual(await response.json(), {
crate_owner_invitations: [
Expand Down Expand Up @@ -92,7 +92,102 @@ module('Mirage | GET /api/v1/me/crate_owner_invitations', function (hooks) {
});

test('returns an error if unauthenticated', async function (assert) {
let response = await fetch('/api/v1/me/crate_owner_invitations');
let response = await fetch('/api/private/crate_owner_invitations');
assert.equal(response.status, 403);
assert.deepEqual(await response.json(), {
errors: [{ detail: 'must be logged in to perform that action' }],
});
});
});

module('Mirage | GET /api/private/crate_owner_invitations', function (hooks) {
setupTest(hooks);
setupMirage(hooks);

test('empty case', async function (assert) {
let user = this.server.create('user');
this.server.create('mirage-session', { user });

let response = await fetch('/api/private/crate_owner_invitations');
assert.equal(response.status, 200);
assert.deepEqual(await response.json(), { crate_owner_invitations: [] });
});

test('returns the list of invitations for the authenticated user', async function (assert) {
let nanomsg = this.server.create('crate', { name: 'nanomsg' });
this.server.create('version', { crate: nanomsg });

let ember = this.server.create('crate', { name: 'ember-rs' });
this.server.create('version', { crate: ember });

let user = this.server.create('user');
this.server.create('mirage-session', { user });

let inviter = this.server.create('user', { name: 'janed' });
this.server.create('crate-owner-invitation', {
crate: nanomsg,
createdAt: '2016-12-24T12:34:56Z',
invitee: user,
inviter,
});

let inviter2 = this.server.create('user', { name: 'wycats' });
this.server.create('crate-owner-invitation', {
crate: ember,
createdAt: '2020-12-31T12:34:56Z',
invitee: user,
inviter: inviter2,
});

let response = await fetch('/api/private/crate_owner_invitations');
assert.equal(response.status, 200);
assert.deepEqual(await response.json(), {
crate_owner_invitations: [
{
crate_id: Number(nanomsg.id),
crate_name: 'nanomsg',
created_at: '2016-12-24T12:34:56Z',
invited_by_username: 'janed',
invitee_id: Number(user.id),
inviter_id: Number(inviter.id),
},
{
crate_id: Number(ember.id),
crate_name: 'ember-rs',
created_at: '2020-12-31T12:34:56Z',
invited_by_username: 'wycats',
invitee_id: Number(user.id),
inviter_id: Number(inviter2.id),
},
],
users: [
{
avatar: user.avatar,
id: Number(user.id),
login: user.login,
name: user.name,
url: user.url,
},
{
avatar: 'https://avatars1.githubusercontent.com/u/14631425?v=4',
id: Number(inviter.id),
login: 'janed',
name: 'janed',
url: 'https://github.com/janed',
},
{
avatar: 'https://avatars1.githubusercontent.com/u/14631425?v=4',
id: Number(inviter2.id),
login: 'wycats',
name: 'wycats',
url: 'https://github.com/wycats',
},
],
});
});

test('returns an error if unauthenticated', async function (assert) {
let response = await fetch('/api/private/crate_owner_invitations');
assert.equal(response.status, 403);
assert.deepEqual(await response.json(), {
errors: [{ detail: 'must be logged in to perform that action' }],
Expand Down
2 changes: 2 additions & 0 deletions tests/mirage/private/crate-owner-invitations/get-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ module('Mirage | GET /api/private/crate_owner_invitations', function (hooks) {
invited_by_username: 'janed',
invitee_id: Number(user.id),
inviter_id: Number(inviter.id),
expires_at: '2017-01-24T12:34:56Z',
},
{
crate_id: Number(ember.id),
Expand All @@ -54,6 +55,7 @@ module('Mirage | GET /api/private/crate_owner_invitations', function (hooks) {
invited_by_username: 'wycats',
invitee_id: Number(user.id),
inviter_id: Number(inviter2.id),
expires_at: '2017-01-31T12:34:56Z',
},
],
users: [
Expand Down