feat: update mirage tests and route handlers for owner invites #5397
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uses `api/private` over `api/v1/me` for mirage pending owner invites endpoint. And also adds the `expires_at` attribute as part of the payload received as found in the `EncodableCrateOwnerInvitationV1` struct from the API.
Turbo87
reviewed
Oct 31, 2022
Turbo87
reviewed
Oct 31, 2022
Turbo87
reviewed
Nov 1, 2022
Turbo87
reviewed
Nov 1, 2022
| return new Response(403, {}, { errors: [{ detail: 'must be logged in to perform that action' }] }); | ||
| } | ||
|
|
||
| return schema.crateOwnerInvitations.where({ inviteeId: user.id }); |
There was a problem hiding this comment.
the new endpoint actually works a little bit different. it supports (and iirc requires) query parameters to determine which invites to show.
LeoBorai
force-pushed
the
feat/update-crate-owner-invitations-mirage
branch
from
9fde45f to
b3034ac
Compare
Turbo87
added
A-frontend 🐹
C-internal 🔧
|
I just realized that there is already an implementation for that route handler and I just forgot about it... 🤦♂️ sorry for the back and forth. I think with this out of the way the next step would be to switch the existing Ember Data code over to using the new endpoint instead. since this PR was AFAIU only about adding the mirage endpoint I'll go ahead and close it until we have a PR that updates the Ember Data code :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses
api/privateoverapi/v1/mefor mirage pending owner invites endpoint.And also adds the
expires_atattribute as part of the payload received asfound in the
EncodableCrateOwnerInvitationV1struct from the API.