Skip to content

Extract sql module with all custom sql_function!() calls #3935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 21, 2021

Conversation

Turbo87
Copy link
Member

@Turbo87 Turbo87 commented Sep 17, 2021

This seems a bit more organized compared to having them scattered all over the place.

@Turbo87 Turbo87 added C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear A-backend ⚙️ labels Sep 17, 2021
@bors
Copy link
Contributor

bors commented Sep 20, 2021

☔ The latest upstream changes (presumably #3901) made this pull request unmergeable. Please resolve the merge conflicts.

Copy link
Member

@JohnTitor JohnTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement 👍

@JohnTitor
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Sep 21, 2021

📌 Commit 67b9c9c has been approved by JohnTitor

@bors
Copy link
Contributor

bors commented Sep 21, 2021

⌛ Testing commit 67b9c9c with merge 742f9fa...

@bors
Copy link
Contributor

bors commented Sep 21, 2021

☀️ Test successful - checks-actions
Approved by: JohnTitor
Pushing 742f9fa to master...

@bors bors merged commit 742f9fa into rust-lang:master Sep 21, 2021
@Turbo87 Turbo87 deleted the sql branch September 21, 2021 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-backend ⚙️ C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants