Remove ChainError trait
#3901
Merged
Remove ChainError trait
#3901
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turbo87
added
C-internal 🔧
Turbo87
force-pushed
the
chain-error
branch
3 times, most recently
from
9701459 to
1b12db7
Compare
For `Option` there is nothing to chain onto, so we might as well use the built-in `ok_or_else()` method to convert the `Option` to a `Result`
Using `map_err()` instead is just a few characters more, but makes it more clear how the original error is chained onto the new error
Turbo87
force-pushed
the
chain-error
branch
from
1b12db7 to
9e40742
Compare
|
@bors r=hi-rustin |
|
📌 Commit 9e40742 has been approved by |
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
chain_error()function can be replaced byok_or_else()(forOption) ormap_err()(forResult), which makes the intent a little clearer, and removes one of the layers of indirection from our error handling, without being significantly more verbose.Please note that this only removes the
ChainErrortrait, but theChainedErrorstruct still exists.