Convert curly component to angle bracket component invocations #2017
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
☔ The latest upstream changes (presumably #2026) made this pull request unmergeable. Please resolve the merge conflicts. |
Turbo87
force-pushed
the
angle-brackets
branch
from
4c4c1f9 to
69f4951
Compare
|
☔ The latest upstream changes (presumably #1994) made this pull request unmergeable. Please resolve the merge conflicts. |
Turbo87
force-pushed
the
angle-brackets
branch
from
69f4951 to
6b5496e
Compare
|
📌 Commit 6b5496e has been approved by |
bors
added a commit
that referenced
this pull request
Dec 21, 2019
Convert curly component to angle bracket component invocations see https://emberjs.github.io/rfcs/0311-angle-bracket-invocation.html the main advantage from this is that arguments and attributes are both first-class citizens now and components invoked with angle bracket syntax can use "modifiers" (see emberjs/rfcs#353)
|
☀️ Test successful - checks-travis |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see https://emberjs.github.io/rfcs/0311-angle-bracket-invocation.html
the main advantage from this is that arguments and attributes are both first-class citizens now and components invoked with angle bracket syntax can use "modifiers" (see emberjs/rfcs#353)